1027478 - Modify telephony API from dialEmergency(number, serviceId) to dialEmergency(number)

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

We don't need to specify the serviceId. Gecko could automatically choose the proper one for the request.

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

In order to land the change smoothly, I suggest to separate it into 3 stages:

1. Gecko automatically select the sim card when dialing emergency call. 
   No interface change. The provided serviceId will be overwritten by gecko's choice.
   => Bug 1031239

2. Gaia modifies the usage of api. Ignore the argument of serviceId. Since this parameter is an optional field. It will not break the interface. Also, the behavior should be the same as stage 1.

3. Gecko modifies the interface. Remove parameter |serviceId|
   => this bug

Comment 2

[Szu-Yu Chen [:aknow] (inactive)]

Hi Anthony,

Step 1 is landed. It's time for gaia to remove the usage of 2nd parameter in dialEmergency(number, serviceId)

Comment 3

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/21935

Comment 4

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8458741 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/21935

I left one comment on the PR for a removal that I think was accidental.

Comment 5

[Anthony Ricaud (:rik)]

Doh! Good catch!

https://github.com/mozilla-b2g/gaia/commit/3c56d1983f46d1d9dce509cdce02e207bce0df29