1027890 - Reject building with pymake

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Now that comm-central builds fine without pymake, it's time to say goodbye. And in fact, since bug 1022348 landed, pymake builds are broken anyways (and the good thing is that few people complained they were failing to build).

Comment 1

[Mike Hommey [:glandium]]

Also, not having to care for pymake helps make the build system changes I'm planning for soon.

Comment 2

[Gregory Szorc [:gps]]

I'll grant r+ without seeing the patch.

Comment 3

[Justin Wood (:Callek)]

We need to ensure l10n and related infra (including release jobs) will work fine without pymake, even when calling the old pymake invoker directly (e.g. python ...make.py) for certain buildbot parts.

I "seem to recall" that we passed directly to mozmake when invoked that way, if in path, but wanted to call it out

Comment 4

[Mike Hommey [:glandium]]

We can surely do this in several steps:
- Remove pymake support from mach (doesn't impact automation)
- Make the change from bug 927672 not fallback to using pymake if mozmake is not present (and here we can see if that breaks l10n)
- Actively reject pymake in config/baseconfig.mk.

For step 2, that essentially depends on whether those builds are using tooltool or not.

Comment 5

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #4)
> For step 2, that essentially depends on whether those builds are using
> tooltool or not.

According to the logs, l10n builds don't use tooltool. (not only on windows, btw)

Comment 6

[Mike Hommey [:glandium]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1027929#c1

Oh, the irony. It would break nightly l10n, but not release l10n.

Comment 7

[Mike Hommey [:glandium]]

Actually, release l10n builds would break for a different reason: they don't run tooltool in the topsrcdir.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Reject builds with pymake

Please do look at this patch ;)

Comment 9

[Mike Hommey [:glandium]]

Attachment: Remove all sorts of build system code dedicated to pymake

Note the weird thing removed from config/rules.mk ; the test didn't work there because L10NBASEDIR is always set (see config/config.mk)

Comment 10

[Gregory Szorc [:gps]]

Comment on attachment 8443377 [details] [diff] [review]
Reject builds with pymake

Review of attachment 8443377 [details] [diff] [review]:
-----------------------------------------------------------------

I think I have a new favorite patch of the year.

::: config/baseconfig.mk
@@ +29,3 @@
>  # strictly above 4.0.
> +ifdef .PYMAKE
> +$(error Pymake is not supported)

Let's make this a little more user friendly since I know some people bypass client.mk and will see this. How about:

Pymake is no longer supported. Please upgrade to MozillaBuild 1.9 or newer and build with 'make'.

Comment 11

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49cadfcde709
https://hg.mozilla.org/integration/mozilla-inbound/rev/bcd694f0e95d

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/59b0072d64aa next to bug 1027497 for B2G Windows build bustage: https://tbpl.mozilla.org/php/getParsedLog.php?id=42399092&tree=Mozilla-Inbound

Comment 13

[Mike Hommey [:glandium]]

Attachment: Reject builds with pymake

What failed at landing is that the b2g simulator thing is back-calling make through the mach code in build_xpi.py. The best idea I have is to export MAKE, and make mach try that value too.

Comment 14

[Mike Hommey [:glandium]]

https://tbpl.mozilla.org/?tree=Try&rev=40b0a677b283

Comment 15

[Gregory Szorc [:gps]]

Comment on attachment 8445628 [details] [diff] [review]
Reject builds with pymake

Review of attachment 8445628 [details] [diff] [review]:
-----------------------------------------------------------------

my reluctant r+ on that b2g simulator patch comes back to bite us.

I'll re-land this for you since I assume you are sleeping.

Comment 16

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/fx-team/rev/8aac3c8dc7bb

(inbound was closed)

Comment 17

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/fx-team/rev/df7a27d2bb7e

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8aac3c8dc7bb

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df7a27d2bb7e
https://hg.mozilla.org/mozilla-central/rev/2ddf136b173d