1027929 - Use tooltool for l10n builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Mike Hommey [:glandium]]

l10n builds should use tooltool on all platforms, using a l10n.manifest file.

Comment 1

[Mike Hommey [:glandium]]

The interesting thing is that afaict, release l10n repacks are actually using tooltool (and using the same manifest as normal builds, which is arguably overkill)

Comment 2

[Mike Hommey [:glandium]]

release l10n repacks are using tooltool, but they're not running it from the top source directory like other builds, so all assumtions about tooltool tools paths are wrong, which makes release l10n builds not use mozmake despite it being downloaded by tooltool.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Run tooltool from within the source directory during l10n repacks

Bug 902084 added tooltool to l10n repacks to get mac builds to use clang, but the fact is the builds never actually picked clang from tooltool and the failures must have been fixed some other way. But since I do want l10n builds to use tooltool, might as well do that properly.

Comment 4

[Mike Hommey [:glandium]]

Attachment: Use a dedicated tooltool manifest for l10n repacks

Since l10n repacks never actually used tooltool-downloaded stuff, might as well avoid the overkill-ness of downloading the same things as normal builds and use a different tooltool manifest.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Add l10n tooltool manifests

AIUI, android builds use a different config for tooltool.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Add tooltool step to nightly repacks

Comment 7

[Mike Hommey [:glandium]]

Attachment: Add tooltool step to nightly repacks

After testing on staging, it appears it needed an adjustment for the workdir to be right during repacks.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Add l10n tooltool manifests

Adding to comm-central configs too.

Comment 9

[Mike Hommey [:glandium]]

Validated with release l10n repacks and nightly l10n repacks on staging.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8443278 [details] [diff] [review]
Add l10n tooltool manifests

Thanks for taking the effort to test these changes. 

re the earlier conversation about release mac l10n, are you planning to create browser/config/tooltool-manifests/macosx64/l10n.manifest ?

Comment 11

[Mike Hommey [:glandium]]

(In reply to Nick Thomas [:nthomas] from comment #10)
> Comment on attachment 8443278 [details] [diff] [review]
> Add l10n tooltool manifests
> 
> Thanks for taking the effort to test these changes. 
> 
> re the earlier conversation about release mac l10n, are you planning to
> create browser/config/tooltool-manifests/macosx64/l10n.manifest ?

Considering we're barely building code during l10n, now, and that it works fine with system clang, I'm not convinced it's worth much.

Comment 12

[Mike Hommey [:glandium]]

https://hg.mozilla.org/build/buildbot-configs/rev/f1afbbb2db7b
https://hg.mozilla.org/build/tools/rev/d5ad563df856
https://hg.mozilla.org/build/buildbotcustom/rev/ce95864ba1b9
https://hg.mozilla.org/build/buildbotcustom/rev/39fd5b73b6c6

Comment 13

[Mike Hommey [:glandium]]

In production