1028143 - Remove dangerous public destructor of MediaPipeline

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

In bug 1027251 we removed all dangerous public destructors of XPCOM-refcounted classes outside of a finite whitelist, see HasDangerousPublicDestructor. Now we are going over the entries in this whitelist.

One of them is: MediaPipeline

Comment 1

[Anuj Agarwal [:anujagarwal464]]

Attachment: bug1028143.diff

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 8454916 [details] [diff] [review]
bug1028143.diff

Review of attachment 8454916 [details] [diff] [review]:
-----------------------------------------------------------------

Same comment as on bug 1028142. I expected this to be not quite so trivial, but I could of course have been wrong.

Comment 3

[Anuj Agarwal [:anujagarwal464]]

@Andrew: Try run was green
https://tbpl.mozilla.org/?tree=Try&rev=f064e98faf66

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 8454916 [details] [diff] [review]
bug1028143.diff

Review of attachment 8454916 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine to me.  It seems odd that it wasn't fixed before, but this code may have just changed around in the last few months.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d8aa5c075e9

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0d8aa5c075e9