Closed
Bug 1028281
Opened 10 years ago
Closed 10 years ago
Do final QA on welcome.webmaker.org snippet landing page
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Webmaker Graveyard
webmaker.org
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: matt, Assigned: andrea)
References
Details
(Whiteboard: [snippet] [june27])
Attachments
(1 file)
No description provided.
Reporter | ||
Updated•10 years ago
|
Whiteboard: [snippet] [june27]
Updated•10 years ago
|
Reporter | ||
Comment 1•10 years ago
|
||
* Andrea: can you do final QA?
Comment 2•10 years ago
|
||
Right now once I fill the form with my email and click the checkbox I receive an email from: tbd[at]mrss.com and the body with subject is still "tbd" Also, it's being redirect correctly to Makerparty page and the URL is: https://party.webmaker.org/?thanks=20140620_snippettest_MPlandingpageTEST01&action_code=FgxRWxYUOVIKQV0YAFcLTFM&td=TVFtSwMxDP4rpZ8Udmd7524vflFEVHQobKCgUnq9bCv22tJrBRX_u6nOl0KgyZM8eZK8U-ilNnROpdHHaMp12m5K5Xo6ogE6HUBFkUJOwYjYJN3tvqKVxri485yP4iVjNhkzooNLQQFiFeOHrKmYGKz2HmKEIYrFrZE2N_JyA6uz5Ypx5BhS-1uGrt86C7980aEasdYGBjp_eMKI3tjkxdqFXnxp4tUUq1QAGUF0cde7YE1RMcJn87qZH7K_DO2F7LqAaU1TVmyCNi05q_4y0gBBoECbuRbuTRsjHw_GJSN7C6m0jW7YHpFLG8EQDJCbJbknnImZqPfJifcG7qC90hFr6klZN2Tv6mK1uB4Ro5-BnIN6dvvkdBtcD48HNfKWfMabko9rspRrGfRPYZa0lT6inDwpH9HWJJxR6uEVAW2_F6C4GkuuZLGetqzgHOpiNp42Bfv3kCpvzMo-b3l3E5KPgkjvumTgB_vaL_34BA Question to JBUCK: Is this suppose to be for prod? 20140620_snippettest_MPlandingpageTEST01 Also, the email content should it be update soon?
Flags: needinfo?(jon)
Updated•10 years ago
|
Assignee: nobody → ali
Comment 3•10 years ago
|
||
Yep, that's the correct thanks tag.
Depends on: 1027724
Flags: needinfo?(jon)
Comment 4•10 years ago
|
||
Blargh. That's the correct thanks tag, and the email copy will be updated in bug 1027724.
Updated•10 years ago
|
Assignee: ali → nobody
Updated•10 years ago
|
Assignee: nobody → andrea
Reporter | ||
Comment 5•10 years ago
|
||
* Andrea: you're going to do final QA on this page, with BSD helping right? http://welcome.webmaker.org/ * Also: can you confirm that snippet traffic won't actually be turned on until Tuesday?
Flags: needinfo?(andrea)
Reporter | ||
Comment 6•10 years ago
|
||
@ Andrea: can you provide final sign off and close this ticket when ready? * Closing this ticket means: yes, we are 100% ready for the snippet.
Assignee | ||
Comment 7•10 years ago
|
||
Hm, looks good! But there are a couple of issues: -- The opt-in checkbox should have a "required" indication, like a red asterisk that is noted at bottom as "required". -- When I submitted my email, checked the box, and clicked "submit" I got this error: https://www.evernote.com/shard/s202/sh/f800aba7-3139-4632-9b2e-bca7d3634d50/cc74685c0d09b8f1b7d18b298f2b8a5a/deep/0/sendto.mozilla.org---snippet-test-and-Inbox-(20530-messages,-2853-unread).png Maybe you're working on it?
Flags: needinfo?(andrea)
Comment 8•10 years ago
|
||
I fixed up the email submission errors, it was due to a style change we made on Friday that accidentally removed some required HTML attributes. I'll make the required indication on the checkbox a bit larger
Reporter | ||
Comment 9•10 years ago
|
||
Thanks Jbuck!
Comment 10•10 years ago
|
||
Attachment #8444586 -
Flags: review?(kate)
Comment 11•10 years ago
|
||
Comment on attachment 8444586 [details] [review] https://github.com/mozilla/webmaker-snippet-landing-page/pull/6 Ignore the browser compatibility comments, since this is ff only
Attachment #8444586 -
Flags: review?(kate) → review+
Comment 12•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker-snippet-landing-page https://github.com/mozilla/webmaker-snippet-landing-page/commit/e0efd6158da4dda79193dc22bae3bd23ee3ccaeb Bug 1028281 - Improve visibility of form errors
Reporter | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Comment 14•10 years ago
|
||
ship it!
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: needinfo?(jon)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•