Closed Bug 1028933 Opened 10 years ago Closed 10 years ago

Hide the context menu ui when the homescreen is not visible

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Homescreen
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog, b2g-v2.0 fixed, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S5 (4july)
Project Flags:
tracking-b2g backlog
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: vingtetun, Assigned: vingtetun)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

bug1028933.patch
4.94 KB, patch
kgrandon
: review+
bajaj
: approval-gaia-v2.0+
Details | Diff | Splinter Review
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-] → [VH-FL-blocking-][VH-FC-blocking?]
Whiteboard: [systemsfe]
Comment on attachment 8444431 [details] [diff] [review]
bug1028933.patch

Review of attachment 8444431 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8444431 - Flags: review?(kgrandon) → review+
What's the user impact of this bug if we don't fix it?
Flags: needinfo?(21)
Assignee: nobody → 21
Status: NEW → ASSIGNED
(In reply to Jason Smith [:jsmith] from comment #3)
> What's the user impact of this bug if we don't fix it?

Same comment as https://bugzilla.mozilla.org/show_bug.cgi?id=1028940#c4
Flags: needinfo?(21)
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking?] → [VH-FL-blocking-][VH-FC-blocking+]
Moving this to backlog doesn't classify a blocker
blocking-b2g: 2.0? → backlog
(In reply to Preeti Raghunath(:Preeti) from comment #5)
> Moving this to backlog doesn't classify a blocker

Minor user impact.
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking+] → [VH-FL-blocking-][VH-FC-blocking-]
Comment on attachment 8444431 [details] [diff] [review]
bug1028933.patch

Review of attachment 8444431 [details] [diff] [review]:
-----------------------------------------------------------------

This is needed for the vertical homescreen.
Attachment #8444431 - Flags: approval-gaia-v2.0?(bbajaj)
Attachment #8444431 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #10)
> v2.0:
> https://github.com/mozilla-b2g/gaia/commit/
> 7edc43f1eecefa612fc28f0982c55a2bd16555e4

Whoops, pasted the wrong link there.

v2.0: https://github.com/mozilla-b2g/gaia/commit/f710da88b402d54a0f5461bc2253eed0b1bd652e
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: