Closed
Bug 1029163
Opened 10 years ago
Closed 10 years ago
https proxying instability
Categories
(Core :: Networking: HTTP, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: mcmanus, Assigned: mcmanus)
References
Details
Attachments
(3 files)
1.14 KB,
patch
|
u408661
:
review+
|
Details | Diff | Splinter Review |
3.09 KB,
patch
|
u408661
:
review+
|
Details | Diff | Splinter Review |
1.88 KB,
patch
|
u408661
:
review+
|
Details | Diff | Splinter Review |
A few problems have been found with https proxying resulting in the usual mishmash of hung sockets and corrupt data on uploads :)
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•10 years ago
|
||
Assignee | ||
Comment 3•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8444728 -
Flags: review?(hurley)
Assignee | ||
Updated•10 years ago
|
Attachment #8444724 -
Flags: review?(hurley)
Assignee | ||
Updated•10 years ago
|
Attachment #8444729 -
Flags: review?(hurley)
Assignee | ||
Comment 4•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=c3aa023be67b
Attachment #8444728 -
Flags: review?(hurley) → review+
Attachment #8444724 -
Flags: review?(hurley) → review+
Attachment #8444729 -
Flags: review?(hurley) → review+
Assignee | ||
Comment 5•10 years ago
|
||
I actually exported the wrong rev of part 1 - this is the interdiff diff --git a/netwerk/protocol/http/TunnelUtils.cpp b/netwerk/protocol/http/TunnelUtils.cpp index 18ce103..4fcae9a 100644 --- a/netwerk/protocol/http/TunnelUtils.cpp +++ b/netwerk/protocol/http/TunnelUtils.cpp @@ -344,17 +344,17 @@ TLSFilterTransaction::WriteSegments(nsAHttpSegmentWriter *aWriter, LOG(("TLSFilterTransaction::WriteSegments %p max=%d\n", this, aCount)); if (!mTransaction) { return NS_ERROR_UNEXPECTED; } mSegmentWriter = aWriter; nsresult rv = mTransaction->WriteSegments(this, aCount, outCountWritten); - if (NS_SUCCEEDED(rv) && NS_FAILED(mFilterReadCode) && !outCountWritten) { + if (NS_SUCCEEDED(rv) && NS_FAILED(mFilterReadCode) && !(*outCountWritten)) { // nsPipe turns failures into silent OK.. undo that! rv = mFilterReadCode; } LOG(("TLSFilterTransaction %p called trans->WriteSegments rv=%x %d\n", this, rv, *outCountWritten)); return rv; }
Assignee | ||
Comment 6•10 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/1f5625271af6 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/650a94cde2d8 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/9cdded2baf00
https://hg.mozilla.org/mozilla-central/rev/1f5625271af6 https://hg.mozilla.org/mozilla-central/rev/650a94cde2d8 https://hg.mozilla.org/mozilla-central/rev/9cdded2baf00
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•