1029178 - Name the GonkMemoryPressureMonitoring thread

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Gonk, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

I was looking at thread names for bug 1027434, and I noticed that each child process had an unnamed thread (inheriting the name "(Nuwa)") due to GonkMemoryPressureMonitoring.  It's a one-line fix (modulo style-required wrapping), so why not.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: bug1029178-name-pressure-thread-hg0.diff

Guessing a reviewer based on the file's commit log.

Comment 2

[Dave Hylands [:dhylands]]

Comment on attachment 8444750 [details] [diff] [review]
bug1029178-name-pressure-thread-hg0.diff

Review of attachment 8444750 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, and the name even fits in 15 characters :)

If I was going to change anything, I'd probably replace the space with a dash, but even that is really just cosmetic (some tools allow specifying a thread by name, and thread names without spaces are slightly easier to use)

Comment 3

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Dave Hylands [:dhylands] (PTO - back Mon Jun 23) from comment #2)
> Looks good to me, and the name even fits in 15 characters :)

There's some template magic that breaks the build if the name doesn't fit, as it happens. (-:

> If I was going to change anything, I'd probably replace the space with a
> dash, but even that is really just cosmetic (some tools allow specifying a
> thread by name, and thread names without spaces are slightly easier to use)

I was following the example set by Analysis Helper, Cache I/O, Cache2 I/O, Cert Verify, DOM Worker, GL updater, HTML5 Parser, Hang Monitor, IPDL Background, Pico Worker, Proxy R~olution, Socket Thread, and localStorage DB (and probably others).  But there are also a bunch of threads in UndelimitedCamelCase, and that works too.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

https://hg.mozilla.org/integration/mozilla-inbound/rev/79452be63899

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/79452be63899