1029934 - User cannot input Rupee symbol

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

Description

[helloarvin]

There's no way to input Rupee symbol especially for India Language IME.

Comment 1

[helloarvin]

Hi luke,

In my opinion, the best way is to support Rupee symbol in all India-Language-IME(bengali-Avro、bengali-Probhat、hindi、Tamil) so that it's very helpful and friendly to all India native users. Hence, I tried to add Rupee symbol in those four IMEs but the issue occurred on Tamil[1] for there's no its own private symbol panel like hindi[2] etc. Obviously, it's not a sound way to modify the common symbol panel. 

So, I think maybe we can create a private symbol panel for tamil (copy from hindi or ...) rather than using common symbol panel[3]. Then the Rupee issue would be fixed easily.

How do you think?

thanks a lot. 

[1] https://github.com/mozilla-b2g/gaia/blob/v1.3t/keyboard/layouts/ta.js
[2] https://github.com/mozilla-b2g/gaia/blob/v1.3t/keyboard/layouts/hi.js#L91-L110
[3] https://github.com/mozilla-b2g/gaia/blob/v1.3t/apps/keyboard/js/layout.js#L8-L35

Comment 2

[Luke Chang [:lchang] (inactive)]

(In reply to helloarvin from comment #1)
> So, I think maybe we can create a private symbol panel for tamil (copy from
> hindi or ...) rather than using common symbol panel[3]. Then the Rupee issue
> would be fixed easily.

Hi Arvin,

It's totally fine. You can create a private symbol panel for Tamil (just copy that from Hindi). As you said, it doesn't make sense to modify the common symbol panel because it will affect other irrelevant keyboards.

There's no private symbol panel in Tamil just because it wasn't necessary formerly. You can add one now for your own purpose.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

let's not add additional scope to Tarako
add to backlog

Comment 4

[helloarvin]

Attachment: add_Rupee_symbol_for_all_INDIA_IMEs.patch

As far as I know, there are four IMEs of India language in v1.3t and they are: 'Bangla - Avro', 'Bangla - Probhat', 'Hindi' and 'Tamil'.

For the first three IMEs, I just add the Rupee symbol and replace the default currency symbol '$' with Rupee(this might be much more reasonable for local user).

Specially, I replace '@' with Rupee symbol in its "shift" key panel. This is because we've discussed the rationality to place '@', '!' and '?' mark on the panel[1,2]. So, to place the Rupee symbol on the panel would be quite convenient and friendly for local user, and meanwhile the changes could be kept to a minimum.

Please help review my patch, thanks a lot.
 
[1]https://bugzilla.mozilla.org/show_bug.cgi?id=991509#c6
[2]https://bugzilla.mozilla.org/show_bug.cgi?id=991509#c10

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8449307 [details] [diff] [review]
add_Rupee_symbol_for_all_INDIA_IMEs.patch

Hi Arvin,

r+ since it looks reasonable. I'd like to know which branch you intend to land this patch? v1.3t or v1.4?

Comment 6

[helloarvin]

(In reply to Luke Chang [:lchang] from comment #5)
> Comment on attachment 8449307 [details] [diff] [review]
> add_Rupee_symbol_for_all_INDIA_IMEs.patch
> 
> Hi Arvin,
> 
> r+ since it looks reasonable. I'd like to know which branch you intend to
> land this patch? v1.3t or v1.4?

Hi Luke,

First of all, we should land it into the branch v1.3t.

Secondly, I think this is a common issue for all branches including master, because it's a very serious problem for all native Indian user cannot input their own currency symbol Rupee via FFOS.

So, can we land the patch to all branches?

Thank you.

Comment 7

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8449307 [details] [diff] [review]
add_Rupee_symbol_for_all_INDIA_IMEs.patch

I just noticed that there's no longer '$' sign on Hindi keyboard which means Hindi users have no way to input '$' sign after this patch landed. Is it correct?

Comment 8

[helloarvin]

Hindi user can still input '$' via common symbol panel[1], and Rupee must be the most frequently used currency symbol rather than '$'. So it is sound to place Rupee in hindi keyboard for native user and support to type '$' via common symbol with a little more steps(first click '?१२३' and then click ALT).

How do you think?

[1] https://github.com/mozilla-b2g/gaia/blob/v1.3t/apps/keyboard/js/layout.js#L36-L57

Comment 9

[Luke Chang [:lchang] (inactive)]

However, there's no common symbol panel in hindi keyboard. Instead, it uses private one which you just modified its '$' sign.

Comment 10

[helloarvin]

Type 'ALT' on the panel I modified '$' sign of hindi keyboard, it will show another symbol panel which is the common panel for all IMEs. Am I right?

Comment 11

[Luke Chang [:lchang] (inactive)]

Yes, you're right. I just got confused with duplicate '$' signs in the common symbol panel.

I can help to land this patch in master branch first. However, you may need to nominate it for v1.3t? again if you need this patch in v1.3t branch.

Comment 12

[helloarvin]

yeah, thank you very much.

I will nominate for both v1.3t and v1.4 later.

Comment 13

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request 21379

Waiting for testing process.

Comment 14

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8450911 [details] [review]
Pull Request 21379

Hi Rudy,

Since this patch will be landed in master branch, could you help to review it? Thanks.

Comment 15

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8450911 [details] [review]
Pull Request 21379

I don't understand why we handle bn-Avro and bn-Probhat differently, and please refer to my comment, 
https://github.com/mozilla-b2g/gaia/pull/21379/files#discussion_r14584685

Arvin, Luke, could you help  to take a look at the above questions?
Thanks.

Comment 16

[helloarvin]

Hi Luke, 

Could you please help explain the question of Rudy on the difference between bn-Avro and bn-Probhat?

As for https://github.com/mozilla-b2g/gaia/pull/21379/files#discussion_r14584685, I just took it for granted that it had been used the same as bn-Avro. I also think we could remove it for it's never been used. How do you think?

Thanks.

Comment 17

[Luke Chang [:lchang] (inactive)]

Hi Arvin,

I think Rudy means that why you changed the "$" sign into Rupee symbol in the alternateLayout of "bn-Probhat" but remained "৳" symbol in the same position in "bn-Avro"? Do you have any idea about making these symbol panels more consistent between two layouts?

Comment 18

[helloarvin]

In the alternateLayout of "bn-Avro", we use "৳" stood for currency symbols so I just add Rupee to the its value-set('৳': '₹ $ € £ ¥').

As for "bn-Probhat", I changed the '$' to Rupee symbol for the latter is the most common currency sign for Hindi user. Due to inertial thinking, I also insert Rupee to the value-set of '৳' and took it for granted that it had been used the same as bn-Avro. In fact, however, it's never been used in "bn-Probhat".

In my opinion, we might replace the '$' sign into "৳" in the alternateLayout of "bn-Probhat" and then what need do is just to add Rupee symbol into its value-set.

Do you think so?

Thanks.

Comment 19

[Luke Chang [:lchang] (inactive)]

(In reply to helloarvin from comment #18)
> In my opinion, we might replace the '$' sign into "৳" in the alternateLayout
> of "bn-Probhat" and then what need do is just to add Rupee symbol into its
> value-set.
> 
> Do you think so?

I personally prefer this way but I have no idea which is better to native users.

Rudy, could you confirm that? Thanks.

Comment 20

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Let's ni the original author about this, since I know nothing about Bangla.

Aniruddha,

could you help take a look at comment 18?
Thank you.

Comment 21

[helloarvin]

Hi aniruddha,

Any update here, thanks?

Comment 22

[Aniruddha Adhikary [:tuxboy]]

I am looking into this tonight, was on vacation for a few days.

Comment 23

[helloarvin]

(In reply to Aniruddha Adhikary from comment #22)
> I am looking into this tonight, was on vacation for a few days.

Any fresh developments?

Please feel free to tell me if anything needs to be improved.
Thanks.

Comment 24

[helloarvin]

Dear Aniruddha Adhikary,

Any fresh developments?
Please feel free to tell me if anything needs to be improved.

Thanks a lot.

Comment 25

[Aniruddha Adhikary [:tuxboy]]

Fixed. https://github.com/mozilla-b2g/gaia/pull/22533

Comment 26

[Aniruddha Adhikary [:tuxboy]]

Attachment: adds rupee sign

Comment 27

[helloarvin]

Dear Aniruddha Adhikary,

BTW, do we need add rupee sign for another two languages 'hi' and 'ta'?

Thanks.

Comment 28

[Aniruddha Adhikary [:tuxboy]]

Hi hellarvin,

Yes, we needed to add rupee sign for 'hi', and I just updated my commit and added it. But, I don't see a key mapped to '$' or any other currency symbol in the 'ta' layout. So, I avoided 'ta'.

And bn-Avro and bn-Probhat are common layouts for Bangla, both originated in Bangladesh and are used in both West Bengal (India) and Bangladesh itself. There is no such case of Probhat being a layout for India and Avro being a layout for Bangladesh!

Comment 29

[helloarvin]

Thank you very much.

As for 'ta', please refer to the comment 4 and feel free to tell me your opinions.
--------------------------------------------------------------------
Specially, I replace '@' with Rupee symbol in its "shift" key panel. This is because we've discussed the rationality to place '@', '!' and '?' mark on the panel[1,2]. So, to place the Rupee symbol on the panel would be quite convenient and friendly for local user, and meanwhile the changes could be kept to a minimum.

[1]https://bugzilla.mozilla.org/show_bug.cgi?id=991509#c6
[2]https://bugzilla.mozilla.org/show_bug.cgi?id=991509#c10

Comment 30

[Aniruddha Adhikary [:tuxboy]]

Just added the rupee symbol in place of the shifted layout's '@' of the 'ta' keyboard.

Comment 31

[helloarvin]

Yeah, I think it's good enough.

Hi Rudy and Luke,

Could you please help review the Aniruddha's PR on adding Rupee symbol?
https://github.com/mozilla-b2g/gaia/pull/22533/files

Thank you all.

Comment 32

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8467962 [details] [review]
adds rupee sign

I'll take a look at this patch.
Thanks.

Comment 33

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8467962 [details] [review]
adds rupee sign

These changes look good to me, r+.
I think you guys are native to these languages so I don't have to find other native speakers to take a look.

Comment 34

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/37b515006398f8b1394c78f5001816ff2e92207b

Comment 35

[helloarvin]

[Blocking Requested - why for this release]: This is a common issue for each branch including v1.4.

Rudy, please help land the patch into the branch v1.4, thank you.

Comment 36

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

This can only land to v1.4 if it got +'ed, and this would need to go through the triage for the decision.

Comment 37

[Wayne Chang [:wchang]]

triage - 1.4+ as required for target launch candidate

Comment 38

[Ryan VanderMeulen [:RyanVM]]

This will need rebasing for v1.4 uplift. Also, please nominate this for v2.0 uplift if it is needed there as well.

Comment 39

[Aniruddha Adhikary [:tuxboy]]

Attachment: rupee symbol fix for v1.4

Comment 40

[Aniruddha Adhikary [:tuxboy]]

Attachment: rupee symbol fix for v2.0

rupee symbol fix for v2.0

Comment 41

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/195df2d81cd5fff0aeffb81924cf5a75d59676ff
v1.4: https://github.com/mozilla-b2g/gaia/commit/4a662f6dd831cf6194d7ad3501b1d56ea2964a20

Thanks!

Comment 42

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

A test case needs to be created to cover this issue

Comment 43

[KTucker [:KTucker][Inactive 3/4/2016]]

Test case added in moztrap:

https://moztrap.mozilla.org/manage/case/14337/

Comment 44

[Luke Chang [:lchang] (inactive)]

Attachment: Pull Request 23126 for v1.4 (hi & ta)

According to Bug 987496 comment 42, we just decided to uplift Hindi and Tamil input methods to v1.4 branch few days ago.

However, this bug has already been uplifted to v1.4 before we uplift those input methods so there is no Hindi and Tamil parts in the uplifted patch. For this reason, I'd like to uplift this patch to v1.4 once more here.

Comment 45

[Luke Chang [:lchang] (inactive)]

Uplifted to v1.4 branch.
https://github.com/mozilla-b2g/gaia/commit/96a35ee90b46aca87623cc85f28ca44b4fd2c909