Closed
Bug 1029966
Opened 10 years ago
Closed 10 years ago
rewrite settings build script in javascript
Categories
(Firefox OS Graveyard :: Gaia::Build, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: yurenju, Assigned: yurenju)
References
Details
Attachments
(1 file)
since we found a way to require r.js in gaia build environement, we can remove Makefile in settings directory and rewrite the code in javascirpt.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → yurenju.mozilla
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•10 years ago
|
||
Alex, could you review this pull request? and I also found we can't get STDOUT from nsIProccess, do you have any idea for that?
Attachment #8445786 -
Flags: review?(poirot.alex)
Comment 2•10 years ago
|
||
Comment on attachment 8445786 [details] [review] github PR: https://github.com/mozilla-b2g/gaia/pull/20970 Looks good, thanks! Can you f?/r? a settings peer so that they know about this ?
Attachment #8445786 -
Flags: review?(poirot.alex) → review+
Comment 3•10 years ago
|
||
(In reply to Yuren [:yurenju] from comment #1) > Created attachment 8445786 [details] [review] > github PR: https://github.com/mozilla-b2g/gaia/pull/20970 > > Alex, could you review this pull request? and I also found we can't get > STDOUT from nsIProccess, do you have any idea for that? Yes... nsIProcess is extremelly old and limited. We now have some new ways to run processes, like child_process (which is supposed to have same API than node): http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/system/child_process.js Or subprocess (child_process is based on it): http://mxr.mozilla.org/mozilla-central/source/addon-sdk/source/lib/sdk/system/child_process/subprocess.js These new APIs allow fine control on std IOs!
Assignee | ||
Comment 4•10 years ago
|
||
follow up bug is filed, bug 1031123
Assignee | ||
Comment 5•10 years ago
|
||
Comment on attachment 8445786 [details] [review] github PR: https://github.com/mozilla-b2g/gaia/pull/20970 offline discussed with Arthur, set review? to him.
Attachment #8445786 -
Flags: review?(arthur.chen)
Comment 6•10 years ago
|
||
Comment on attachment 8445786 [details] [review] github PR: https://github.com/mozilla-b2g/gaia/pull/20970 Looks good to me, thank you!
Attachment #8445786 -
Flags: review?(arthur.chen) → review+
Assignee | ||
Comment 7•10 years ago
|
||
rebase to master and push try server again: https://tbpl.mozilla.org/?rev=314f9585446fb7b90c150703c57fddbb41d732d9&tree=Gaia-Try
Assignee | ||
Comment 8•10 years ago
|
||
merged. https://github.com/mozilla-b2g/gaia/commit/d6976b6954437bd317dd9e36fab27e0f86213d2f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 9•10 years ago
|
||
b2g-inbound: https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=73730a9f374d
You need to log in
before you can comment on or make changes to this bug.
Description
•