103064 - New context menu items

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, enhancement, P2)

Description

[Peter Trudelle]

This is a meta bug representing the planning and design work for this feature,
the actual work will be represented by dependency bugs for the subtasks. If you
want to discuss any of this at length, please do so in the appropriate newsgroup
(UI,browser,perf,...), and just add a link to the discussion in this bug report.
 Here is our current plan for this:
--------------------------
New Context Menu Options

1) Set Image As Wallpaper
(Windows only)
- Ability to obtain in-memory bitmap representation for a given image in a
document - 3 days (conservative)
- Write this representation to disk in the correct location, as "Brandname
Wallpaper" -  2 days (conservative)
- menu item UI - 1 day.

2) Save Page as Text
- Develop scheme for formatting HTML input into sensible text output. At 
simplest, this could just be outputting non tag elements to a file. If so,
swag - 3 days for back end, 1 day for menu item. Alternative option could 
leverage mail code for converting formatted mail into plain text to do the same
task, assuming their system uses a clever scheme. 5 days for this route,  1 day
for menu item. This feature seems less useful to me personally, as if  you want
the text of a page, you can always select the content blocks
visually and paste into an editor. Better copy and paste handling would tend  to
make those types of operations more successful.

3) Save page with Images - this is the useful one. Involves:
- creating a folder on disk under where the file was saved for page objects,
with name "filenamesavedto files" - 1 day
- search through the document for objects to save, as a base line this would 
include - images, included javascript files (imported via script tag), and
included stylesheets (imported via link tag). - 3 days
- initiate downloads of those individual items.  - 4 days
Total - 7 days including menu item. (conservative)

4) Send Page, Edit Page - one day inclusive, just involves adding UI

Before we add anything to the context menus, we should do some cleaning of 
what's in there already. It is currently heavy in many cases, and the code
behind it is confusing. Blake has volunteered to help with this in 0.9.5
---------------------
This plan needs review and r= approval.

Comment 1

[sairuh (rarely reading bugmail)]

bug 75338 is the context menu UI uber bug.

Comment 2

[Bill Law]

r=law for the plan and design

I've posted some comments on design alternatives to n.p.m.browser.

Comment 3

[Peter Trudelle]

Added separate plan page for this at
http://mozilla.org/xpapps/MachVPlan/Context_Menu_Options.html

Forgot to list suggested requirements:
    * Ability to set image as wallpaper
    * Ability to save a page as text only or complete with images
    * Ability to send page
    * Ability to edit page in composer
    * Investigate/spec out alternative ways to expose context menu functionality

P2/096

Comment 4

[Gervase Markham [:gerv]]

You may want to collect the number of other bugs on these proposed features
which are lying around Bugzilla, and which have much useful discussion in them.
To start you off, the Set As Wallpaper bug is bug 41526.

Gerv

Comment 5

[Gervase Markham [:gerv]]

How was the decision within Netscape made to have these items in the context
menu (as opposed to anywhere else) for Mach V? Only one of the five (Set As
Wallpaper) is context-sensitive.

Gerv

Comment 6

[Peter Trudelle]

Thanks Gerv, I did see that, but wasn't sure if it was a good idea to just
reassign it and make it a dependency. As for a 'decision', there has been none
so far, only some suggested requirements from marketing, and an engineering
plan-in-progress. I put all this out onto mozilla.org/Bugzilla so we could get
the plan right. Thanks for helping!  We're already discussing your last comment
in n.p.m.browser...

Comment 7

[jag (Peter Annema)]

Also see bug 103591 "Improved Image Managent".

Comment 8

[Jesse Ruderman]

I think this bug should be wontfixed.

- Saving a page as text or with images should be options in the file picker 
dialog or in the File menu, not in the context menus.  

- "Edit page" is not a common operation.

- "Send page" will encourage users include entire web pages in their e-mails 
rather sending a link, which is annoying because the page might have updated, 
and because the recipient might not using a mail reader that supports every 
element in the web page (html, javascript, pngs).

- UI for setting wallpapers should be provided by the OS, not web browsers.  If 
you include the option in the browser, you'll have to choose between 
overwriting "Mozilla wallpaper.bmp" each time "set as wallpaper" is chosen, or 
creating a new file each time, neither of which is what the user wants.

Comment 9

[Peter Trudelle]

Please don't fixate on the summary, that was just how the feature request came
to us, and is not necessarily how these commands will be exposed.  In any case,
discussion of how to do this belongs in the newsgroups, not in this tracking bug. 

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

Attachment: "Edit Page/Link", "Send Page/Link" implementation (not quite a real apply-able patch)

Comment 11

[Paul Chen]

Comment on attachment 55041 [details] [diff] [review]
"Edit Page/Link", "Send Page/Link" implementation (not quite a real apply-able patch)

r=pchen assuming Ben can get a version that CAN be applied ;-)

Comment 12

[David Hyatt]

sr=hyatt

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

This patch checked in. 

Comment 14

[R.K.Aa.]

there's now a crash on mail startup: bug 107334

Comment 15

[Markus Gerstel]

This patch includes 3 ^M in editor/ui/composer/content/editorNavigatorOverlay.xul

Comment 16

[Daniel Bratell]

>  2) Save Page as Text

 The conversion functionality already exist in the nsPlainTextSerializer in
layout (or is it content?) It is used by mail but also by copy/paste (try to
select a full page, copy and paste into your favorite text editor (emacs)). Its
functionality is much better than NS4.x' but it's not a full layout engine which
would be necessary to make "perfect" text output.

Akkana among others would know how to use it. I only know how it works. :-)

Comment 17

[Boris Zbarsky [:bzbarsky]]

This caused bug 107568

Comment 18

[Akkana Peck]

nsIDocumentEncoder (with a mime type of text/plain) is the currently recommended
API for getting at the plaintext serializer.  But there are plans in the works
to integrate this with other APIs; JST says there's a standard document-saving
interface being considered by the W3C, and we want to try to track that if we
can get a preview of it.

Comment 19

[sujay]

context menu items do not work in composer. Please see bug 108084

Is 108084 a DUP of this bug?

Comment 20

[[not reading bugmail]]

also as per n.p.m.general  - block images from this server are gone from the
browser context menu.

Comment 21

[[not reading bugmail]]

looks like blocked images had returned a few days later between 11-04 and this
comment 11-11 builds from hidden context menu problems.

Comment 22

[Jeremy M. Dolan]

2 and 3 (save as text, save with images/etc) should simply be added to the
current  save dialog, with "Save entire page" the default, so it's exposed more.
"Save HTML only" and "Save as plain text" would be selectable from a dropdown. I
think this is in line with IE.

Comment 23

[Ben Goodger (use ben at mozilla dot org for email)]

sending to joe, as he has the remainder of this work.

Comment 24

[Jeremy M. Dolan]

> 1) Set Image As Wallpaper

How about puting this in page info->images? Page info has a lot of potential but
doesn't do or show anything useful right now. I can't even block/unblock/save
images from there.

> 4) Send Page, Edit Page

These are not context operations.

Why isn't this being integrated with the current work at
http://mozilla.org/projects/ui/menus/shortcut/ rather then being tacked on the
the awful current menus.

Comment 25

[timeless]

please pay attention to comment 9.

Comment 26

[Jaime Rodriguez, Jr.]

This bug is targetted for M101. Should we remove it from blocking Bug 102472,
since its current target is outside the dev window for the next release?

Comment 27

[Peter Trudelle]

nsbeta1+, Moz1.0

Comment 28

[Joe Hewitt (gone)]

all of these context menus are in already

Comment 29

[sairuh (rarely reading bugmail)]

right. rs vrfy --see specific bugs in dep tree.