Closed
Bug 1030675
Opened 10 years ago
Closed 10 years ago
Handle search app crashes
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Firefox OS Graveyard
Gaia::System
Tracking
(blocking-b2g:2.0+, b2g-v2.0 fixed, b2g-v2.1 fixed)
People
(Reporter: vingtetun, Assigned: vingtetun, NeedInfo)
References
Details
(Whiteboard: [systemsfe])
Attachments
(2 files)
1.09 KB,
patch
|
kgrandon
:
review+
|
Details | Diff | Splinter Review |
2.87 KB,
patch
|
kgrandon
:
review+
|
Details | Diff | Splinter Review |
If the the search app crashes (for oom or any other reasons), then it never comes back until the the system is restarted.
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8446438 -
Flags: review?(kgrandon)
Updated•10 years ago
|
Updated•10 years ago
|
blocking-b2g: 2.0? → 2.0+
Comment 2•10 years ago
|
||
Comment on attachment 8446438 [details] [diff] [review] bug1030675.patch Review of attachment 8446438 [details] [diff] [review]: ----------------------------------------------------------------- This is much better, thanks.
Attachment #8446438 -
Flags: review?(kgrandon) → review+
Updated•10 years ago
|
Assignee: nobody → 21
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=acfe1796253b741aeab61d3949d3210b9f68b908
Updated•10 years ago
|
status-b2g-v2.0:
--- → affected
status-b2g-v2.1:
--- → affected
Updated•10 years ago
|
Target Milestone: --- → 2.0 S5 (4july)
Assignee | ||
Comment 4•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/49fc74b6dc1f13911f33abf696a01b6da586307f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 5•10 years ago
|
||
v2.0: https://github.com/mozilla-b2g/gaia/commit/553c9ce714e72d9e8a2bb97bfb56bf508ca7964b
Assignee | ||
Comment 6•10 years ago
|
||
Seems like a typo in the code prevent this to work...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 7•10 years ago
|
||
Kevin, I fixed the typo and add more tests in order to make sure this stuff does not happen again.
Attachment #8447616 -
Flags: review?(kgrandon)
Updated•10 years ago
|
Comment 8•10 years ago
|
||
Comment on attachment 8447616 [details] [diff] [review] bug1030675.followup.patch Review of attachment 8447616 [details] [diff] [review]: ----------------------------------------------------------------- ::: apps/system/js/rocketbar.js @@ +871,5 @@ > > this._port = 'pending'; > navigator.mozApps.getSelf().onsuccess = function() { > var app = this.result; > + if (!app) { Is this a possible case? I just haven't seen this before, so wasn't sure this is needed everywhere we do getSelf(). If this is only for unit testing, I would prefer to use a mock object. But it won't block the review.
Attachment #8447616 -
Flags: review?(kgrandon) → review+
Assignee | ||
Comment 9•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Gaia-Try&rev=a9521c0914ba3cb08020a2cfd0000926cdf1ade2
Assignee | ||
Comment 10•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/22b23f4f884dc0bf195075102d0d598f39b8b189
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Comment 11•10 years ago
|
||
v2.0: https://github.com/mozilla-b2g/gaia/commit/f5f7943d754ebdc074997cc92ca7ac51830952e0
Comment 12•9 years ago
|
||
Hi Repoter, Could you provide the detailed reproduce steps for me to verify this bug? Thank you!
Flags: needinfo?(21)
You need to log in
before you can comment on or make changes to this bug.
Description
•