Closed Bug 1030675 Opened 10 years ago Closed 10 years ago

Handle search app crashes

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

defect
Not set
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 fixed, b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S5 (4july)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: vingtetun, Assigned: vingtetun, NeedInfo)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files)

If the the search app crashes (for oom or any other reasons), then it never comes back until the the system is restarted.
Blocks: 1015336
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking+]
Whiteboard: [systemsfe]
blocking-b2g: 2.0? → 2.0+
Comment on attachment 8446438 [details] [diff] [review]
bug1030675.patch

Review of attachment 8446438 [details] [diff] [review]:
-----------------------------------------------------------------

This is much better, thanks.
Attachment #8446438 - Flags: review?(kgrandon) → review+
Assignee: nobody → 21
Status: NEW → ASSIGNED
Target Milestone: --- → 2.0 S5 (4july)
Seems like a typo in the code prevent this to work...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Kevin, I fixed the typo and add more tests in order to make sure this stuff does not happen again.
Attachment #8447616 - Flags: review?(kgrandon)
Comment on attachment 8447616 [details] [diff] [review]
bug1030675.followup.patch

Review of attachment 8447616 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/system/js/rocketbar.js
@@ +871,5 @@
>  
>        this._port = 'pending';
>        navigator.mozApps.getSelf().onsuccess = function() {
>          var app = this.result;
> +        if (!app) {

Is this a possible case? I just haven't seen this before, so wasn't sure this is needed everywhere we do getSelf(). If this is only for unit testing, I would prefer to use a mock object. But it won't block the review.
Attachment #8447616 - Flags: review?(kgrandon) → review+
https://github.com/mozilla-b2g/gaia/commit/22b23f4f884dc0bf195075102d0d598f39b8b189
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Hi Repoter,
    Could you provide the detailed reproduce steps for me to verify this bug?

Thank you!
Flags: needinfo?(21)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: