Closed
Bug 1030678
Opened 10 years ago
Closed 10 years ago
Rename the "Bug suggestions" tab to "Failure summary"
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: jfrench)
References
()
Details
The "Bug suggestions" tab is treeherder's equivalent of the annotated failure summary - however every time I'm looking a the UI it takes me a moment to realise what I'm looking for, when changing between tabs (when a job is selected). I think we should call it "Failure summary" or something similar, since showing the failures is the primary purpose, and then showing bug suggestions for each failure is an added bonus, as it were. (We're going to have failures for which there are no bug suggestions, in which case the current tab title doesn't make sense).
Assignee | ||
Comment 1•10 years ago
|
||
I have something working locally; it seems to be behaving properly. I'm just confirming some grunt stuff with the folks on IRC. If that's sorted successfully I'll assign myself this bug and open a PR.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → tojonmz
Assignee | ||
Comment 2•10 years ago
|
||
I talking with camd on IRC we concluded grunt wasn't really applicable for the sole html change in dist/ so I've made that change manually. There was also one css class I/we believe are unused, so I removed that during the work. Otherwise everything is related to the renaming work. I will submit a PR shortly, make prelim comments there, and cross reference it here.
Assignee | ||
Comment 3•10 years ago
|
||
https://github.com/mozilla/treeherder-ui/pull/83
Assignee | ||
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•10 years ago
|
||
The PR has been r+'d, pushed and deployed to Staging for Ed to have a look at and verify. https://treeherder.allizom.org
Assignee | ||
Updated•10 years ago
|
Reporter | ||
Comment 5•10 years ago
|
||
lgtm, thank you :-) https://github.com/mozilla/treeherder-ui/commit/b209d01fd561d13de8ba0f0236b3cd1431427011
Assignee | ||
Comment 6•10 years ago
|
||
Thanks Ed. I will mark Resolved based on that feedback. As always, we can re-open if there's any issues.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•10 years ago
|
Severity: normal → minor
Priority: -- → P2
You need to log in
before you can comment on or make changes to this bug.
Description
•