1030716 - Prevent dark theme in sourceeditor for WebIDE

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Paul Rouget [:paul]]

When the dark theme is used, itchpad turns dark and the toolbox as well. When the file list and the toolbar don't.

I see 2 options:
- not support the dark theme in webide
- support dark theme for file list, and (optional) the toolbar

Comment 1

[Brian Grinstead [:bgrins]]

My first thought here is to disable theming for the editor for now to make it feel less broken, then come back around to adding full theme support later (possibly under a different pref than the one being used by the toolbox).

Comment 2

[Paul Rouget [:paul]]

(In reply to Brian Grinstead [:bgrins] from comment #1)
> My first thought here is to disable theming for the editor for now to make
> it feel less broken

Works for me. How to do that?

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: no-dark-theme.patch

this does the trick.  What do you think? It adds a special attribute to the html element that theme-switching.js picks up and forces it to stick with the specified theme.

We can't just *not* include theme-switching.js unless if we want to do the StylesheetUtils.loadSheet stuff (and maybe forceStyle) inside of editor.js, but that would be an option too.

Comment 4

[Brian Grinstead [:bgrins]]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=ee3d43d207d1

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/25e196a33884

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/25e196a33884