1030730 - Fix running jstests from the command line

Status: RESOLVED INVALID

(Core :: JavaScript Engine, defect)

Description

[Andy Wingo [:wingo]]

Since bug 1029059, jstests no longer work from the command line.  The attached patch fixes it.

Comment 1

[Andy Wingo [:wingo]]

Attachment: Fix running jstests from the command line

Comment 2

[Nathan Froyd [:froydnj]]

Does this exhibit the same behavior for all the tests that test XPCOMABI?

Comment 3

[Nathan Froyd [:froydnj]]

(I backed out bug 1029059 on inbound, but I wouldn't object to being able to check the target in a much cleaner way in jstests, which is what this patch does.)

Comment 4

[Andy Wingo [:wingo]]

(In reply to Nathan Froyd (:froydnj) from comment #2)
> Does this exhibit the same behavior for all the tests that test XPCOMABI?

I believe so.  If you grep the tests for ABI you'll find that the only check that's made is match(/x86_64/), which this patch preserves.

Comment 5

[Jason Orendorff [:jorendorff]]

Comment on attachment 8446505 [details] [diff] [review]
Fix running jstests from the command line

Review of attachment 8446505 [details] [diff] [review]:
-----------------------------------------------------------------

Clearing review.

The offending patch was apparently backed out. It looks like this would be the right change though, so r=me if it recurs!

Comment 7

[Andy Wingo [:wingo]]

Closing as invalid as no activity in 5 years and of course jstests run just fine from the command line :)