Closed
Bug 1030781
Opened 10 years ago
Closed 10 years ago
Refactor camera app object
Categories
(Firefox OS Graveyard :: Gaia::UI Tests, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zcampbell, Assigned: zcampbell)
Details
Attachments
(1 file)
The camera app object is a bit of a mess. * Reduce/merge locators * bolster logic and waits * etc
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → zcampbell
Assignee | ||
Comment 1•10 years ago
|
||
adhoc: http://selenium.qa.mtv2.mozilla.com:8080/job/b2g.flame.mozilla-central.ui.adhoc/39/
Attachment #8447122 -
Flags: review?(florin.strugariu)
Attachment #8447122 -
Flags: review?(andrei.hutusoru)
Assignee | ||
Comment 2•10 years ago
|
||
Last one was no good, I hadn't rebased to pick up the latest marionette/runner. http://selenium.qa.mtv2.mozilla.com:8080/job/b2g.flame.mozilla-central.ui.adhoc/40/
Comment 3•10 years ago
|
||
Comment on attachment 8447122 [details] [review] git pr Only a nit
Attachment #8447122 -
Flags: review?(florin.strugariu) → review+
Updated•10 years ago
|
Attachment #8447122 -
Flags: review?(andrei.hutusoru) → review+
Assignee | ||
Comment 4•10 years ago
|
||
(In reply to Florin Strugariu [:Bebe] from comment #3) > Comment on attachment 8447122 [details] [review] > git pr > > Only a nit Yep one indentation was wrong
Assignee | ||
Updated•10 years ago
|
Attachment #8447122 -
Flags: review+ → review?(florin.strugariu)
Updated•10 years ago
|
Attachment #8447122 -
Flags: review?(florin.strugariu) → review+
Comment 5•10 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/99884d5d941fac026ed0ce116a8234d360c14200
Assignee | ||
Comment 7•10 years ago
|
||
Nah, this is just an enhancement, no need for v2.0.
Flags: needinfo?(zcampbell)
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•