Closed Bug 1030781 Opened 10 years ago Closed 10 years ago

Refactor camera app object

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Other
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zcampbell, Assigned: zcampbell)

Details

Attachments

(1 file)

46 bytes, text/x-github-pull-request
AndreiH
: review+
Bebe
: review+
Details | Review
The camera app object is a bit of a mess.

* Reduce/merge locators
* bolster logic and waits
* etc
Assignee: nobody → zcampbell
Attached file git pr
adhoc:
http://selenium.qa.mtv2.mozilla.com:8080/job/b2g.flame.mozilla-central.ui.adhoc/39/
Attachment #8447122 - Flags: review?(florin.strugariu)
Attachment #8447122 - Flags: review?(andrei.hutusoru)
Last one was no good, I hadn't rebased to pick up the latest marionette/runner.
http://selenium.qa.mtv2.mozilla.com:8080/job/b2g.flame.mozilla-central.ui.adhoc/40/
Comment on attachment 8447122 [details] [review]
git pr

Only a nit
Attachment #8447122 - Flags: review?(florin.strugariu) → review+
Attachment #8447122 - Flags: review?(andrei.hutusoru) → review+
(In reply to Florin Strugariu [:Bebe] from comment #3)
> Comment on attachment 8447122 [details] [review]
> git pr
> 
> Only a nit

Yep one indentation was wrong
Attachment #8447122 - Flags: review+ → review?(florin.strugariu)
Attachment #8447122 - Flags: review?(florin.strugariu) → review+
Do we want this on 2.0 too?
Flags: needinfo?(zcampbell)
Nah, this is just an enhancement, no need for v2.0.
Flags: needinfo?(zcampbell)
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: