1031132 - mach environment duplicates logic from MachCommandBase

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

When mach environment was written, MachCommandBase didn't exist. Now, the checks in mach environment are redundant with what MachCommandBase does. However, its error handling for ObjdirMismatchException is better than that of MachCommandBase.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Refactor mach environment to use logic from MachCommandBase instead of its own

Also don't print section titles when there is nothing under them, and move
move the ObjdirMismatchException handling to MachCommandBase.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Refactor mach environment to use logic from MachCommandBase instead of its own

mozconfig path was missing.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8446951 [details] [diff] [review]
Refactor mach environment to use logic from MachCommandBase instead of its own

Review of attachment 8446951 [details] [diff] [review]:
-----------------------------------------------------------------

More unified code. W00t.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ee4eaf0c38e

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ee4eaf0c38e

Comment 6

[Kai-Zhen Li [:seinlin][:kli]]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/7d48aee15106