1031254 - [Vertical Homescreen] Add configure button in context menu

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Cristian Rodriguez (:crdlc)]

I wanted to open this bug just because of I would like to show a new option like "Settings or Configure" in the contextmenu once that the pinch-to-zoom was removed from 2.0.

Could we have a new option in the context menu like:

----
Settings or Configure...
----
Change Wallpaper
----
Add Smart Collections

----
Cancel

When an user click on this new option an activity would be performed in order to show the setting app in the homescreen panel thought

Is a good idea? or maybe an stupid thing XD

Comment 1

[Cristian Rodriguez (:crdlc)]

What do you think? Many thanks

Comment 2

[Francis Djabri [:djabber]]

That sounds like a great idea to me. What do you think Jacqueline?

Comment 3

[Jacqueline Savory [:jsavory] UX]

I think this is a great idea as well, perhaps "Homescreen Settings" would work as the option. However I don't think we can add anymore strings to 2.0. Cristian do you know if there is an existing string that we can use in this situation?

Comment 4

[Cristian Rodriguez (:crdlc)]

Sadly I don't see any string related to "Homescreen Settings"

https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/locales/homescreen.en-US.properties

(In reply to jsavory from comment #3)
> I think this is a great idea as well, perhaps "Homescreen Settings" would
> work as the option. However I don't think we can add anymore strings to 2.0.
> Cristian do you know if there is an existing string that we can use in this
> situation?

Comment 5

[Cristian Rodriguez (:crdlc)]

uff I added a wrong link. This is the locales that the vertical homescreen has right now

https://github.com/mozilla-b2g/gaia/blob/master/apps/verticalhome/locales/homescreen.en-US.properties

Comment 6

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Just in case you want to test the feature in the device

Comment 7

[Cristian Rodriguez (:crdlc)]

Attachment: Screenshots of the implementation

Comment 8

[Jacqueline Savory [:jsavory] UX]

I think that this looks great, but you're right, I don't think we can use any of the strings listed... perhaps we can include this for 2.1?

Comment 9

[Cristian Rodriguez (:crdlc)]

ok for 2.1

Comment 10

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8447853 [details]
Github pull request

thanks Kevin

Comment 11

[Cristian Rodriguez (:crdlc)]

Ready for 2.1

(In reply to jsavory from comment #8)
> I think that this looks great, but you're right, I don't think we can use
> any of the strings listed... perhaps we can include this for 2.1?

Comment 12

[Kevin Grandon :kgrandon]

Comment on attachment 8447854 [details]
Screenshots of the implementation

Let's ask for a UI review from Jacqueline first..

Comment 13

[Jacqueline Savory [:jsavory] UX]

Comment on attachment 8447854 [details]
Screenshots of the implementation

This looks like it works for me.

Comment 14

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/47f797c1f22ea4a6adfb1b0a4c34c657977e27b3

Comment 15

[Shally Li（leave from Mozilla）]

This issue has been successfully verified on Flame 2.1.
See attachments: verified_v2.1_1.png and verified_v2.1_2.png.
Reproduce rate: 0/5

Flame 2.1 build:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141201.034405
FW-Date         Mon Dec  1 03:44:15 EST 2014
Bootloader      L1TC00011880

Comment 16

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.1_1.png

Comment 17

[Shally Li（leave from Mozilla）]

Attachment: verified_v2.1_2.png