1031553 - b2g crashes during enabling data connection

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect, P1)

Description

[Tapas[:tkundu on #b2g/gaia/memshrink/gfx] (always NI me)]

Attachment: stack trace

Test steps:
1. Run music, send sms, call another phone from test device in automation.
2. Enable data connection on the device.
3. Device is rebooting and mini dumps are generated on the phone.

STR will be very difficult to follow but if you can give us right direction then we can enable additional logs which may help debugging this crash

Comment 1

[Tapas[:tkundu on #b2g/gaia/memshrink/gfx] (always NI me)]

Attachment: extra file

This crash is happening multiple times on FFOS 2.0, msm8610 256MB device.

gaia: https://www.codeaurora.org/cgit/quic/lf/b2g/mozilla/gaia/tag/?h=0a25eff60fcc699687e45ba2ac8b9a3ab3782672&id=AU_LINUX_GECKO_B2G_KK_3.6.01.04.00.000.016
gecko: https://www.codeaurora.org/cgit/quic/lf/b2g/mozilla/gecko/tag/?h=0b83d5e6a54df9bfccdbb5ba662527bf657f5381&id=AU_LINUX_GECKO_B2G_KK_3.6.01.04.00.000.016

Comment 2

[cafbot (PoC: ggrisco)]

Crash observed on: 

Device: msm8610
Gonk Version: AU_LINUX_GECKO_B2G_KK_3.6.01.04.00.000.016
Moz BuildID: 20140623000201
B2G Version: 2.0
Gecko Version: 32.0a2
Gaia:  http://git.mozilla.org/?p=releases/gaia.git;a=commit;h=729f214b887ce8efe7d870145d31acb2c6427817
Gecko: http://git.mozilla.org/?p=releases/gecko.git;a=commit;h=f3721e7a9961f09722975d0d76af31130f8847ef

Comment 3

[Michael Vines [:m1] [:evilmachines]]

This also reproduces on v2.0 7x27a builds.

Comment 4

[Michael Vines [:m1] [:evilmachines]]

(Seen 90 times in the last week on v2.0 across all devices)

Comment 5

[cafbot (PoC: ggrisco)]

Observed on: 

Device: msm8610
Gonk Version: AU_LINUX_GECKO_B2G_KK_3.6.01.04.00.000.020
Moz BuildID: 20140628000201
B2G Version: 2.0
Gecko Version: 32.0a2
Gaia:  http://git.mozilla.org/?p=releases/gaia.git;a=commit;h=91958625774ebe6c425adf322b09f1edf906578d
Gecko: http://git.mozilla.org/?p=releases/gecko.git;a=commit;h=eab4f8ff82758f08f049e14d305e29fcc50cb292

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Tapas Kumar Kundu from comment #0)
> Created attachment 8447427 [details]
> stack trace

The crash happens withing egl library. We do not have a source code of egl library :-(

Comment 7

[Sotaro Ikeda [:sotaro]]

Bug 1029856 might affect to this bug.

Comment 8

[Sotaro Ikeda [:sotaro]]

It seems very difficult to reproduce the problem. one possibility is "gralloc buffer is null". As another possible cause, Bug 1029856 or Bug 1031527 might related to this bug.

Comment 9

[Tapas[:tkundu on #b2g/gaia/memshrink/gfx] (always NI me)]

(In reply to Sotaro Ikeda [:sotaro] from comment #6)
> (In reply to Tapas Kumar Kundu from comment #0)
> > Created attachment 8447427 [details]
> > stack trace
> 
> The crash happens withing egl library. We do not have a source code of egl
> library :-(

I also agree :). I am wondering whether any operation of gecko can lead to this crash in our code or not. 
I will try with test patch from bug 1029856 and bug 1031527 to see whether that is the root cause of this issue or not.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add more validity checks to GrallocTextureSourceOGL

Comment 11

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8448239 [details] [diff] [review]
patch - Add more validity checks to GrallocTextureSourceOGL

Review of attachment 8448239 [details] [diff] [review]:
-----------------------------------------------------------------

This patch worries me. I'm sort of worried that this patch is covering up a more serious issue and will make it harder to find. Do we have any idea why the GrallocTextureHost is no longer valid in these cases?

Comment 12

[Sotaro Ikeda [:sotaro]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #11)
> Comment on attachment 8448239 [details] [diff] [review]
> patch - Add more validity checks to GrallocTextureSourceOGL
> 
> Review of attachment 8448239 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This patch worries me. I'm sort of worried that this patch is covering up a
> more serious issue and will make it harder to find. Do we have any idea why
> the GrallocTextureHost is no longer valid in these cases?

There are two possibliteis.
- TextureHost does not have gralloc buffer since it's construction.
- TextureClient/TextureParent is destroyed and TextureClient had TextureFlags::DEALLOCATE_CLIENT flag.

Comment 13

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8448239 [details] [diff] [review]
patch - Add more validity checks to GrallocTextureSourceOGL

Clear review request. I am going to address the concern.

Comment 14

[cafbot (PoC: ggrisco)]

Observed on: 

Device: msm8610
Gonk Version: AU_LINUX_GECKO_B2G_KK_3.6.01.04.00.000.017
Moz BuildID: 20140624000201
B2G Version: 2.0
Gecko Version: 32.0a2
Gaia:  http://git.mozilla.org/?p=releases/gaia.git;a=commit;h=9d2f7bd16a8dc0c74c97c5a40d2f0731f3dfff4b
Gecko: http://git.mozilla.org/?p=releases/gecko.git;a=commit;h=32c226e5a7adbb95e9c4ee003dc9e64699da03e1

Comment 15

[cafbot (PoC: ggrisco)]

Observed on: 

Device: msm8610
Gonk Version: AU_LINUX_GECKO_B2G_KK_3.6.01.04.00.000.021
Moz BuildID: 20140630000201
B2G Version: 2.0
Gecko Version: 32.0a2
Gaia:  http://git.mozilla.org/?p=releases/gaia.git;a=commit;h=c0c8ad187c0466285f2580531e09f8322996f561
Gecko: http://git.mozilla.org/?p=releases/gecko.git;a=commit;h=ef0781044f85ee7f364236c074ab0b7644c38ff8

Comment 16

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Create GrallocTextureSourceOGL only when GrallocTextureHostOGL has a gralloc buffer

Change the patch based on the comment. Did the following changes.
- TextureClient create TextureHost only when the TextureClient allocated buffer.
- Create GrallocTextureSourceOGL only when GrallocTextureHostOGL has a gralloc buffer
- GrallocTextureHostOGL forgets GrallocTextureSourceOGL when GrallocTextureHostOGL forgets the gralloc buffer.
- Add pointer checks to GrallocTextureHostOGL

Comment 17

[Sotaro Ikeda [:sotaro]]

https://tbpl.mozilla.org/?tree=Try&rev=e45ede8a62c6

Comment 18

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8449671 [details] [diff] [review]
patch - Create GrallocTextureSourceOGL only when GrallocTextureHostOGL has a gralloc buffer

Cancel jeff's review. nical's review+ is enough.

Comment 19

[Sotaro Ikeda [:sotaro]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/b7f8089105b2

Comment 20

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/b7f8089105b2

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/967f80f8409e

Comment 22

[Robert Mead [:RobertM]]

New test case needs to be added. There is no existing test case.

Comment 23

[KTucker [:KTucker][Inactive 3/4/2016]]

This is done with Automation. No test case added to moztrap.

Comment 24

[Adam Alldredge [:AdamA][Inactive]]

Unable to verify this issue because it is an automation crash.