103189 - ::first-letter pseudo elements show no border property

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Dylan Schiemann]

Steps to reproduce:
1) Set border properties on first-letter pseudo element

Expected Bahvior:
1) Border around first-letter

Actual Behavior:
1) No Border is visible
This may be a regression.  Builds as recent as 0.9.2 would show a border for
first-letter pseudo elements, but 0.9.4 does not.  Testcase to follow

Comment 1

[Dylan Schiemann]

Attachment: testcase: set first-letter pseudo element to have a 3px black border

Comment 2

[basic]

guess this is a regression.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This sounds like it's more likely to be a layout problem than style system.

Comment 4

[Marc Attinasi]

99% sure this regressed with the rule tree landing. It worked in the 05-31
build, but not in the 06-01 build. Reassign to hyatt and putting [RULETREE] in
summary

Comment 5

[David Hyatt]

Oh boy oh boy oh boy!

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oh, there's code to do this intentionally in nsHTMLCSSStyleSheet.  It just has
to be removed in the right way.

Comment 7

[Peter Trudelle]

What effect will this have on users of MachV?

Comment 8

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Adding a "Dropped Initial" feature to Composer, I just discovered this bug too.
We don't draw borders on :first-letter.

IE and Opera don't have this bug. Konqueror has same bug.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: bring the :first-letter/:first-line rules in nsHTMLCSSStyleSheet mostly up to spec

This is a preliminary patch.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It might be a better solution if we did this work in nsRuleNode.cpp like we do
for :before and :after, though...

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: slightly better patch; still some problems

This one at least compiles and runs without assertions.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Taking the bug.  This really needs to be a post-resolve callback, though.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

And while I think of it, this should be fixed for XML documents too...

Comment 14

[Greg K.]

Also observed using FizzillaCFM/2002061014. Marking All/All.

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 188654 has been marked as a duplicate of this bug. ***

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Doing it in the post resolve callback or in ApplyStyleFixups will break if
someone does something like 'margin: inherit' and gets the struct from the
parent, unless we go through a lot of work.  I think I'll just go with what I
have for now.

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

Basically just updated.

Comment 18

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 113147 [details] [diff] [review]
patch

+  // Disable everything in the Display struct except 'float' and
+  // 'clear'.

This should be moved down to just before the code that actually does it, no?

With that, looks good...

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in to trunk, 2003-02-22 11:20 PST.  Still more work to be done here,
so leaving open, at least until I file a separate bug on the various issues
mentioned above.

Comment 20

[Anne (:annevk)]

What about those new bugs?

Comment 21

[Mats Palmgren (inactive)]

Attachment: Testcase - margin:inherit

David, is this the case you mentioned in comment 16?

Comment 22

[Eli Friedman]

Is there still something left to be done here?

Comment 23

[j.j.]

Mozilla/5.0 (Windows NT 5.1; rv:7.0.1) Gecko/20100101 Firefox/7.0.1

The bug as reported is fixed.
Attachment 166811 [details] (comment 21) should be a seperate bug.