1032127 - tooltool upload should set file permissions to world readable

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Nick Thomas [:nthomas] (UTC+12)]

Did my first upload with https://wiki.mozilla.org/ReleaseEngineering/Applications/Tooltool#How_to_upload_to_tooltool, and I hadn't paid any attention to the permissions set on the stage files. They happened to be 640, which wasn't changed by the upload, so the files weren't visible to Apache.

How about we enforce 644, or at least a=r.

Comment 1

[Simone Bruno [:simone]]

Attachment: tooltool_01.patch

After copying, explicitly sets permissions to 644

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8452997 [details] [diff] [review]
tooltool_01.patch

Review of attachment 8452997 [details] [diff] [review]:
-----------------------------------------------------------------

::: sync.py
@@ +240,5 @@
>                              try:
> +                                target_filename = os.path.join(destination, "temp%s" % digest)
> +                                shutil.copy(digest_path, target_filename)
> +                                # 420 is decimal for 644 (octal), sets permission to -rw-r--r-- to make sure the file is readable
> +                                os.chmod(target_filename, 420)

Can you replace 420 with 0644 (with leading zero) please. It's more readable. The comments would look simpler in this case. :)

Otherwise looks good to me.

Comment 3

[Simone Bruno [:simone]]

Great! I did not figure out I could just put 0644. Thanks!

Comment 4

[Simone Bruno [:simone]]

Comment on attachment 8452997 [details] [diff] [review]
tooltool_01.patch

Checked in, https://github.com/mozilla/build-tooltool/commit/df387e9144ddc88a698bf01595984c1373094a7d

Comment 5

[Simone Bruno [:simone]]

Deployed on relengwebadm.private.scl3.mozilla.com.