Closed
Bug 1032417
Opened 10 years ago
Closed 10 years ago
nsPluginElement destructor defined in header file causes compile error
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jmorton, Assigned: jmorton)
Details
Attachments
(1 file, 1 obsolete file)
1.01 KB,
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
nsPluginElement's destructor is defined directly in the header class declaration, which causes compile errors if it can't see the nsMimeType header, which it doesn't explicitly include: Compile error: http://pastebin.com/raw.php?i=LEcZLLt5 Currently on m-c the unified binding includes are grouped in such a way that masks this error, but changes that cause nsPluginElement.h to be included before something that can see nsMimeType surfaces the error.
Assignee | ||
Comment 1•10 years ago
|
||
This should fix the error by moving the offending destructor to the implementation file.
Attachment #8448240 -
Flags: review?(khuey)
Comment on attachment 8448240 [details] [diff] [review] Bug-1032417-Move-nsPluginElement-Destructor.patch Review of attachment 8448240 [details] [diff] [review]: ----------------------------------------------------------------- Do you want to rebase this to remove the include added in https://hg.mozilla.org/integration/mozilla-inbound/rev/510cb3e9dcdb ?
Attachment #8448240 -
Flags: review?(khuey) → review-
btw you defined a ctor out of line, not a dtor ...
Assignee | ||
Comment 4•10 years ago
|
||
Rebase and fix unforgivable stupidity
Attachment #8448261 -
Flags: review?(khuey)
Attachment #8448240 -
Attachment is obsolete: true
Attachment #8448261 -
Flags: review?(khuey) → review+
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jmorton
https://hg.mozilla.org/integration/mozilla-inbound/rev/231c5bbd4a75
Flags: in-testsuite-
Comment 6•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/231c5bbd4a75
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•