1032708 - Keep discovery alive when WiFi network changes

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The discovery socket is dropped on b2g devices if the WiFi network changes, goes to sleep, etc.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Restart discovery when network changes

We listen for a message on b2g whenever the network changes, and restart any sockets that were open previously.

Try: https://tbpl.mozilla.org/?tree=Try&rev=e5e667d3cec1

Comment 2

[Paul Rouget [:paul]]

Comment on attachment 8449023 [details] [diff] [review]
Restart discovery when network changes

+  this.observe = this.observe.bind(this);

I'm not sure this is necessary.

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Restart discovery when network changes (v2, paul: r+)

(In reply to Paul Rouget [:paul] (slow to respond. Ping me on IRC) from comment #2)
> Comment on attachment 8449023 [details] [diff] [review]
> Restart discovery when network changes
> 
> +  this.observe = this.observe.bind(this);
> 
> I'm not sure this is necessary.

You're right, it's not.  Removed!

Also, I changed this slightly to only restart if the active network is WiFi.

Try: https://tbpl.mozilla.org/?tree=Try&rev=4861df991499

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/167888bcb787

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/167888bcb787