1032799 - Make B2GDesktop Mulet-ready

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[:gerard-majax]

In bug 1030679 we want Gaia UI tests to be ran against Mulet. After investigating this, we need to hack GeckoInstance from marionette_client package and add the -chrome command line arguments.

Once this is done, we can run those tests against this build.

Comment 1

[:gerard-majax]

Attachment: 0001-Bug-1032799-Pass-chrome-argument-to-B2G-Desktop.patch

Please find attached a patch that does the job. It works on my local system, but before asking for review, I'd like a feedback:
 - are you okay with the way it's done
 - is there any tests I should update (I found none when searching)
 - is there any try I should run ?

Thanks!

Comment 2

[Jonathan Griffin (:jgriffin)]

Does this break compatibility with the existing B2G desktop build runs?  If not, it's probably ok.

There aren't any unit tests of this code that need to be updated.

You should run this through try with syntax:  -b o -p linux64_gecko -u all -t none

Comment 3

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8448824 [details] [diff] [review]
0001-Bug-1032799-Pass-chrome-argument-to-B2G-Desktop.patch

Review of attachment 8448824 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/geckoinstance.py
@@ +79,5 @@
>  class B2GDesktopInstance(GeckoInstance):
>      required_prefs = {"focusmanager.testmode": True}
>  
> +    def __init__(self, **kwargs):
> +        GeckoInstance.__init__(self, **kwargs)

The preferred way to do this is:

super(B2GDesktopInstance, self).__init__(**kwargs)

Comment 4

[:gerard-majax]

(In reply to Jonathan Griffin (:jgriffin) from comment #2)
> Does this break compatibility with the existing B2G desktop build runs?  If
> not, it's probably ok.
> 
> There aren't any unit tests of this code that need to be updated.
> 
> You should run this through try with syntax:  -b o -p linux64_gecko -u all
> -t none

No, there should be no compatibility breakage :).

Comment 5

[:gerard-majax]

Attachment: 0001-Bug-1032799-Pass-chrome-argument-to-B2G-Desktop.patch

Initializing the parent class via super(). I'll toggle the review once Try is green.

Comment 6

[:gerard-majax]

Pending try: https://tbpl.mozilla.org/?tree=Try&rev=a2b2e3ea1880

Comment 7

[:gerard-majax]

Comment on attachment 8449248 [details] [diff] [review]
0001-Bug-1032799-Pass-chrome-argument-to-B2G-Desktop.patch

Okay, try is green: https://tbpl.mozilla.org/?tree=Try&rev=a2b2e3ea1880

Comment 8

[Jonathan Griffin (:jgriffin)]

Comment on attachment 8449248 [details] [diff] [review]
0001-Bug-1032799-Pass-chrome-argument-to-B2G-Desktop.patch

Review of attachment 8449248 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 9

[:gerard-majax]

Jonathan, don't we need to push version and release a new python package.

Comment 10

[Jonathan Griffin (:jgriffin)]

(In reply to Alexandre LISSY :gerard-majax from comment #9)
> Jonathan, don't we need to push version and release a new python package.

No, TBPL uses in-tree Marionette; only extra-tree harnesses need Python packages, and none of those need to support Mulet yet.  We'll pick this up the next time we release a Python package for other reasons.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/64d49532fea3

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/64d49532fea3