1033223 - [Vertical homescreen] Intermittent MarionetteJS failure on Travis: 1) Vertical - Bookmark Uninstall removal of bookmark: NoSuchElement: (7) Unable to locate element: gaia-confirm[data-type="remove"]

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Julien Wajsberg [:julienw]]

1) Vertical - Bookmark Uninstall removal of bookmark:

NoSuchElement: (7) Unable to locate element: gaia-confirm[data-type="remove"]

Remote Stack:

<none>

at Error.MarionetteError (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/error.js:67:13)

at Object.Client._handleCallback (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:476:19)

at /home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:510:21

at TcpSync.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/drivers/tcp-sync.js:100:10)

at Object.send (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:457:36)

at Object.Client._sendCommand (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:503:19)

at Object._findElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1303:19)

at Object.findElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-client/lib/marionette/client.js:1352:32)

at Object.MarionetteHelper.waitForElement (/home/travis/build/mozilla-b2g/gaia/node_modules/marionette-helper/index.js:139:19)

at Object.Home2.getConfirmDialog (/home/travis/build/mozilla-b2g/gaia/apps/verticalhome/test/marionette/lib/home2.js:78:31)

at Object.Home2.confirmDialog (/home/travis/build/mozilla-b2g/gaia/apps/verticalhome/test/marionette/lib/home2.js:87:23)

at Context.<anonymous> (/home/travis/build/mozilla-b2g/gaia/apps/verticalhome/test/marionette/bookmark_uninstall_test.js:59:10)

Comment 1

[Julien Wajsberg [:julienw]]

https://travis-ci.org/mozilla-b2g/gaia/jobs/28913478

Comment 2

[Julien Wajsberg [:julienw]]

https://travis-ci.org/mozilla-b2g/gaia/jobs/28895588

Comment 3

[Anthony Ricaud (:rik)]

Kevin: Could you prioritize this accordingly in your team?

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Comment 5

[Kevin Grandon :kgrandon]

Currently testing this fix on travis: https://travis-ci.org/KevinGrandon/gaia/builds/28977727

Comment 6

[Julien Wajsberg [:julienw]]

Disabled in Travis only in:
master: 721823f356bc0b1691d5b2fd87169fb60efae80b

I don't see it failing on TBPL these days.

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8188b3c5c114

Comment 8

[Kevin Grandon :kgrandon]

Seems to be failing a lot on TBPL these days, so disabled there as well: https://github.com/mozilla-b2g/gaia/commit/2d6b361c13a45fb2b4f47da35ac7f12e6cc20106

Comment 9

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Reviving this PR.

Comment 10

[Kevin Grandon :kgrandon]

Comment on attachment 8505785 [details] [review]
Github pull request

Just needed to add one line to resolve this, so going to land with r=me. This just adds a home.moveIconToIndex(icon, 0); which is what we do in almost all other tests. I'm guessing this is some marionette issue.

Comment 11

[Kevin Grandon :kgrandon]

Master: https://github.com/mozilla-b2g/gaia/commit/20dcee03f370d2a681a9519bcf1b538749a18293

Comment 12

[Julien Wajsberg [:julienw]]

At one point, I'd like to experiment sleeping for some time after scrolling instead of moving the icon to prevent scrolling at all.

One guess I have is that because scrolling is now asynchronous, calling scrollIntoView does not have an immediate effect.

Comment 13

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.