1033289 - [ADU By Sig] Add Date Range Selectors

Status: VERIFIED FIXED

(Socorro :: Webapp, task, P3)

Description

[Schalk Neethling [:espressive]]

Based on user feedback in https://bugzilla.mozilla.org/show_bug.cgi?id=1019262 it is clear that the users need to be able to select their own date range for the graph.

Loading the graph initially using the selected number of days for the overall page should still happen however.

Comment 1

[Schalk Neethling [:espressive]]

Thinking about these date selectors, and the channel selector that is made available if no version was passed to report/list

Would it not make sense to always have these selectors available?

That way, whether there was data or not, you can change the date range and/or the channel and reload the graph without having to navigate around or reload the entire page.

Comment 2

[Benjamin Smedberg]

That would be fine.

Comment 3

[Robert Kaiser]

(In reply to Schalk Neethling [:espressive] from comment #1)
> Would it not make sense to always have these selectors available?

Yes, probably makes sense.

Comment 4

[Schalk Neethling [:espressive]]

While testing the work on this bug I ran into a scenario where there is only one result returned for the query:

{
"hits": [
{
"build_date": "2014-06-29", 
"os_name": "Windows", 
"buildid": "20140629004001", 
"adu_count": 2185, 
"crash_count": 1919, 
"adu_date": "2014-07-05", 
"signature": "nsTArray_base<nsTArrayFallibleAllocator, nsTArray_CopyWithConstructors<JS::Heap<JSObject*> > >::IncrementLength(unsigned int) | mozilla::net::HttpBaseChannel::ApplyContentConversions()", 
"product_name": "Firefox", 
"channel": "aurora"
}
], 
"total": 1
}

In the above case, the code here:
https://github.com/mozilla/socorro/blob/master/webapp-django/crashstats/crashstats/static/crashstats/js/socorro/report_list_graph.js#L111

removes this single instance as the adu_count value is not greater that the cutoff (the cutoff value in fact being equal to the adu_count) and as such the following line fails:
https://github.com/mozilla/socorro/blob/master/webapp-django/crashstats/crashstats/static/crashstats/js/socorro/report_list_graph.js#L125

because finalData[0] is undefined

Possible solutions
------------------

1) We can test whether finalData still contains any items after the filter on line #111 has run
2) We only execute the filter if there are more than one item in finalData (the object build up by d3.nest())
3) We can change the filter to - return if d.values.adu_count >= cutoff;

:bsmedberg thoughts?

Comment 5

[Benjamin Smedberg]

#1 sounds like the simplest option.

Comment 6

[Schalk Neethling [:espressive]]

(In reply to Benjamin Smedberg  [:bsmedberg] from comment #5)
> #1 sounds like the simplest option.

So, what would be an accurate message to the user in these cases? There was no error in loading the data and, there was some data returned, the data was just not sufficient? i.e.

'Insufficient data to draw graph.'

Comment 7

[Benjamin Smedberg]

Yes, that's fine.

Comment 8

[Schalk Neethling [:espressive]]

QA Tests
---------

Open crash-stats home
Navigate to top crashers and select a signature
On report/list, click the graph tab.

There are two loaders (spinners) on this tab.
-- First will be a loader indicating the content is loading
-- Following this loader will be another indicating that the graph is being loaded

NOTE: Depending on network speed, these might go past very quick and might not even be observed.

NO DATA
--------

If there is no data for the graph, the user should be presented with a message such as the following:


No data returned for signature EnterBaseline


WITH DATA
----------

The graph should be displayed to the right of the form field.

There should at all times be three form field visible to the user, channel select drop down, a start and end date input (currently these require manual input and no date picker is provided).

Date Validation
----------------

The date validation rules are as follows:

1) Dates cannot be in the future
2) The start date cannot be after the end date.

NOTE: Also test this tab by clicking on a signature on the search results page.

Comment 9

[Schalk Neethling [:espressive]]

Pull request: https://github.com/mozilla/socorro/pull/2195

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d93c09e0b9c70a174b16b0807ae3a01f8be307b8
Fix Bug 1033289, add date fields, make channel selector permanent

https://github.com/mozilla/socorro/commit/681e13a0e31665f601199bde7c9ea6a7612e926d
Merge pull request #2195 from ossreleasefeed/bug1033289-adubysig-add-date-selectors

Fix Bug 1033289, add date fields, make channel selector permanent