1033330 - UI updating after adding/removing a jobname filter takes longer than TBPL

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

1) Go to https://treeherder.mozilla.org/ui/#/jobs?repo=mozilla-inbound
2) Wait for the page to fully load.
3) Click in the filter field top-right of the UI, type in "marionette".
4) Press enter & observe time taken for the UI to update.
5) Delete the text in the filter field and repeat step 4.
6) Repeat steps 2-5 with https://tbpl.mozilla.org/?tree=Mozilla-Inbound (use the "job name" filter under the "filters" menu).

Expected:
Same time or quicker than TBPL for the UI to update

Actual:
TBPL updates virtually instantly. Treeherder takes ~1.5-2 seconds to add the filter, and ~2.5 seconds to remove the filter.

Comment 1

[Cameron Dawson [:camd]]

We should actually move the global "field filters" section to the nav bar where we have the type-in filter.  But that field should allow you to specify which field you're filtering on.  And then it will add a little "chicklet" to the bar to indicate filtering is happening on that field.

Comment 2

[Cameron Dawson [:camd]]

Attachment: pull request

Comment 3

[Cameron Dawson [:camd]]

(In reply to Cameron Dawson [:camd] from comment #1)
> We should actually move the global "field filters" section to the nav bar
> where we have the type-in filter.  But that field should allow you to
> specify which field you're filtering on.  And then it will add a little
> "chicklet" to the bar to indicate filtering is happening on that field.

this is a different bug: bug 1046927

Comment 4

[Cameron Dawson [:camd]]

The fix for this takes the filter time to ~1 second for adding or removing.  It's still a bit slower than TBPL.  But hopefully this moves it into the acceptable range.  

https://github.com/mozilla/treeherder-ui/commit/dbc7d5c22481df76057289d53649dc61aab6afd0

Comment 5

[Ed Morley [:emorley]]

Looking good - thank you :-)