Closed
Bug 1033365
Opened 10 years ago
Closed 10 years ago
Header text in bookmarks activity is misaligned
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cwiiis, Unassigned)
Details
Attachments
(2 files)
Screenshot
The header text does not appear centered in the bookmarks activity.
|
||
Comment 1•10 years ago
|
||
That's because the header has 2 h1 elements, one only being visible at each time. This messes up with the text size calculations. So we need to detect when the h1 visibility changes and emit a `lazyload` event.
|
|
||
Comment 2•10 years ago
|
||
This PR fixes the header (add and edit modes). Cristian, can you review it?
Attachment #8451541 -
Flags: review?(crdlc)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8451541 [details] [review] Github PR LGTM, r+
Attachment #8451541 -
Flags: review?(crdlc) → review+
|
|
||
Comment 4•10 years ago
|
||
Thanks Cristian, it has landed: https://github.com/mozilla-b2g/gaia/commit/6a1a5250852b8a44f7d16a7dd961d76f25534ee0
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•