Closed
Bug 1033570
Opened 10 years ago
Closed 10 years ago
In-content dialogs close-icon too wide with HiDPI
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file)
902 bytes,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
The in-content dialog close-icon is to wide with HiDPI.
Assignee | ||
Comment 1•10 years ago
|
||
The close-icon button used on in-content dialogs has a button-box in his structure. This patch adds a selector to also fit for the width: 16px.
Comment 2•10 years ago
|
||
Comment on attachment 8449651 [details] [diff] [review] close-iconFix.patch Review of attachment 8449651 [details] [diff] [review]: ----------------------------------------------------------------- r+ assuming you tested it and it fixes the problem, as I didn't. :)
Attachment #8449651 -
Flags: review?(dolske) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 3•10 years ago
|
||
Hi, could you provide a Try link. Suggestions for what to run if you haven't yet can be found here: https://wiki.mozilla.org/Sheriffing/How:To:Recommended_Try_Practices
Updated•10 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 4•10 years ago
|
||
Isn't it to much to let go through the try building for a one line CSS patch? But I'll start one.
Assignee | ||
Comment 5•10 years ago
|
||
Try: https://tbpl.mozilla.org/?tree=Try&rev=b0b6ba3bfd27
Keywords: checkin-needed
Comment 6•10 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #4) > Isn't it to much to let go through the try building for a one line CSS patch? Indeed. Tomcat, try to use your judgement in such situations :)
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/043995106767
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/043995106767
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla33
Updated•10 years ago
|
Summary: In-content dialogs close-icon to wide with HiDPI → In-content dialogs close-icon too wide with HiDPI
You need to log in
before you can comment on or make changes to this bug.
Description
•