1033935 - Enable MediaCodecReader by default.

Status: RESOLVED INVALID

(Core :: Audio/Video: Playback, defect)

Description

[Bruce Sun [:brsun]]

This is a followup bug of bug 904177. MediaCodecReader should be enabled only after all the existing capability of MediaOmxReader have been integrated in it.

Comment 1

[Steven Yang [:styang]]

mark feature-b2g: 2.2? to review if we can make it on v2.2.

Comment 2

[Keven Kuo [:kkuo]]

This should be part of 2.2.

--
Keven

Comment 3

[Benjamin Chen [:bechen]]

push to try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=29b2f437a041

Comment 4

[Benjamin Chen [:bechen]]

According to the log:
https://hg.mozilla.org/mozilla-central/filelog/940118b1adcd/dom/media/omx/MediaCodecReader.cpp

Bug 1114910, Bug 1118632, Bug 1120247, Bug 1091467, these 4 patches and need to uplift to 2.2 .

Comment 5

[Sotaro Ikeda [:sotaro]]

(In reply to Benjamin Chen [:bechen] from comment #3)
> push to try:
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=29b2f437a041

Tryserver does not do actual testing for MediaCodec. Current tryserver do actual testing only on ICS on gonk. And MediaCodec is supported since JB. Therefore, if MediaCodec is enabled as default. It's capability is not tested on tryserver :-(

Comment 6

[StevenLee[:slee]]

(In reply to Sotaro Ikeda [:sotaro] from comment #5)
> Tryserver does not do actual testing for MediaCodec. Current tryserver do
> actual testing only on ICS on gonk. And MediaCodec is supported since JB.
> Therefore, if MediaCodec is enabled as default. It's capability is not
> tested on tryserver :-(
Yes, jlal's team is trying to get emulator-kk auto-testing online. We should able to test MediaCodec after that.

Comment 7

[StevenLee[:slee]]

Set bug 1107678 as blocker to make sure we have automatic testing on try server.

Comment 8

[Benjamin Chen [:bechen]]

Attachment: enableMediaCodec.patch

Comment 9

[Sotaro Ikeda [:sotaro]]

(In reply to StevenLee[:slee] from comment #7)
> Set bug 1107678 as blocker to make sure we have automatic testing on try
> server.

Nice!

Comment 10

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8558425 [details] [diff] [review]
enableMediaCodec.patch

Review of attachment 8558425 [details] [diff] [review]:
-----------------------------------------------------------------

reivew+ if bug 1107678 is fixed.

Comment 11

[Sotaro Ikeda [:sotaro]]

The change might have some regression risks. One regression risk is power consumption during pause.

Comment 12

[Blake Wu [:bwu][:blakewu]]

(In reply to Sotaro Ikeda [:sotaro] from comment #11)
> The change might have some regression risks. One regression risk is power
> consumption during pause.
yes. IIRC, that regression is only on CAF platform. 
IMHO, we should try to avoid having this platform specific power saving mechanism as possible as we can.
Extending our dormant mechanism might be a more generic and cross-platform solution on power saving.

Comment 13

[Blake Wu [:bwu][:blakewu]]

See also Bug 1033931 for power saving on pause.

Comment 14

[Inder]

Do we know why this fix has not yet landed on v2.2? AFAICT, it has all the approvals for a while.

Comment 15

[Sotaro Ikeda [:sotaro]]

This bug is for MediaCodec usage for media playback. It is not related to video recording via mozCamera API.

Comment 16

[StevenLee[:slee]]

As comment 15, remove blocker flag.