1034489 - [FirefoxOS_v1.4][Shark]Close WIFI while obtaining IP from AP and WIFI button can't be tapped for long

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Zhenqing Liu]

STR:
  1. Open WIFI.
  2. Tap to connect to a network.
  3. Close WIFI while obtaining IP address.

Sometimes WIFI button can't be tapped for long.

Comment 1

[Zhenqing Liu]

I tried several times and analyse the logs from our tester. Root cause for this bug is a SIGNAL_POLL cmd is dilivered after the TERMINATE one.
 
07-03 13:58:49.261   166   422 D WifiHW  : CMD   :IFNAME=wlan0 TERMINATE
07-03 13:58:49.261   166   422 D WifiHW  : CMD   :IFNAME=wlan0 SIGNAL_POLL

In the end, the SIGNAL_POLL cmd timed out.

07-03 13:58:59.271   166   422 D WifiHW  : 'IFNAME=wlan0 SIGNAL_POLL' command timed out.

So delay is increased for about 10s.

Comment 2

[Vincent Chang[:vchang][changyihsin]]

I think it's very similar with Bug 1009725. The command timeout pends the others command in the same thread.

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.0

Stop connection information timer right after we terminate wpa_supplicant.

Comment 4

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Comment on attachment 8454234 [details] [diff] [review]
Patch v1.0

Review of attachment 8454234 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/wifi/WifiWorker.js
@@ +589,5 @@
>    manager.connectionDropped = function(callback) {
> +    // It's likely that we have terminated the connection to wpa_supplicant.
> +    // Stop the polling timer immediately to prevent connection info update
> +    // command blocking in control thread until socket timeout.
> +    notify("stopconnectioninfotimer");

I think it's better to send notification before we terminate wpa_supplicant[1] than here, in case timer is triggered before the callback(which calls connectionDropped) function of executing terminateSupplicant() is called.

[1] http://hg.mozilla.org/mozilla-central/file/e1a037c085d1/dom/wifi/WifiWorker.js#l1064

Comment 5

[Vincent Chang[:vchang][changyihsin]]

Attachment: Patch v1.1

Addressing the review comments.

Comment 6

[Chuck Lee [:chucklee, Triggered by NI, Review, and Feedback requests]]

Comment on attachment 8456714 [details] [diff] [review]
Patch v1.1

Review of attachment 8456714 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, Thank you!

Comment 7

[Vincent Chang[:vchang][changyihsin]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3fb8e38d7ce5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3fb8e38d7ce5

Comment 9

[Zhenqing Liu]

Hi Vincent, when will this patch be landed?

Comment 10

[Vincent Chang[:vchang][changyihsin]]

Which branches do you want it be landed?

Comment 11

[Zhenqing Liu]

(In reply to Vincent Chang[:vchang] from comment #10)
> Which branches do you want it be landed?

V1.4, on which the bug appears.

Comment 12

[Zhenqing Liu]

07-28 03:47:11.373 D/WifiHW  (  108): CMD   :IFNAME=wlan0 TERMINATE
07-28 03:47:11.373 D/WifiHW  (  108): CMD   :IFNAME=wlan0 DISCONNECT

07-28 03:47:21.383 D/WifiHW  (  108): 'IFNAME=wlan0 DISCONNECT' command timed out.

Hi Vincent, I just find this when I verify your patch. DISCONNECT command after the TERMINATE one will also increase the delay for 10s.

Comment 13

[Vincent Chang[:vchang][changyihsin]]

(In reply to Zhenqing Liu from comment #12)
> 07-28 03:47:11.373 D/WifiHW  (  108): CMD   :IFNAME=wlan0 TERMINATE
> 07-28 03:47:11.373 D/WifiHW  (  108): CMD   :IFNAME=wlan0 DISCONNECT
> 
> 07-28 03:47:21.383 D/WifiHW  (  108): 'IFNAME=wlan0 DISCONNECT' command
> timed out.
> 
> Hi Vincent, I just find this when I verify your patch. DISCONNECT command
> after the TERMINATE one will also increase the delay for 10s.

Hi Zhenqing, thanks for your testing. I filed Bug 1045039.