1034608 - Update the gaiatest webserver to serve app manifest files with the correct content-type

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect, P2)

Description

[Florin Strugariu [:Bebe]]

In Bug 1032745 - Update test_homescreen_delete_app to use local content.  

We need the ability to install webapps. For this the server must serve content with the header "application/x-web-app-manifest+json"

Can we update the web server to contain this header?

Comment 1

[Zac C (:zac)]

This is all done from Marionette so I'll see if the Marionette team can do it.

Comment 2

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Marionette uses mozhttpd as a web server. It should be possible to add the appropriate content type for manifest files, however I'm unsure if this should go into mozhttpd itself, the Marionette test runner, or even the Gaia test runner. As it's related to the tests, I suspect the Gaia test runner (gaiatest) would be the most appropriate place, however we may need changes in Marionette test runner to allow this.

Will: I'm guessing you're most familiar with mozhttpd, do you have any suggestions?

Comment 3

[William Lachance (:wlach)]

Yes, it should be pretty easy to use mozhttpd for this, just define a handler function with the appropriate headers. See the json response decorator for an example of this:

http://hg.mozilla.org/mozilla-central/file/f93c0ef45597/testing/mozbase/mozhttpd/mozhttpd/handlers.py

I suspect it would make the most sense if the logic for doing this was in the gaia test runner, but I'm not very familiar with either its structure or that of that marionette test runner so can't give much guidance there.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21749/files

Comment 5

[Zac C (:zac)]

Comment on attachment 8456069 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21749/files

r+, works very well. Surprised, it didn't look too painful in the end.
(tested in the context of the other pull request)

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8456069 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/21749/files

Nice!

Comment 7

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Landed in:
https://github.com/mozilla-b2g/gaia/commit/2196e6268d2ff901dc0af87333803112f17e9091

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c1ec5c6d584e