Closed
Bug 1035005
Opened 10 years ago
Closed 10 years ago
Marketplace page for not-public apps has title "Loading..." even though no "loading" is happening
Categories
(Marketplace Graveyard :: General, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: kngo)
Details
Attachments
(1 file)
|
48.01 KB,
image/png
|
Details |
screenshot
STR: 1. Visit https://marketplace.firefox.com/app/podcasts (This should bring up a page that says: "Oh no! The app requested is not public.") 2. Inspect the window's title bar, or the tab's label (which show you the page's <title>). ACTUAL RESULTS: The title is "Loading... | Firefox Marketplace", even though there is no "Loading..." going on. EXPECTED RESULTS: Title shouldn't have "Loading..." in it. Should perhaps have some "Error" / "Not Public" / etc. label instead.
|
Reporter | |
Updated•10 years ago
|
Summary: Marketplace page for not-public apps has title "Loading..." → Marketplace page for not-public apps has title "Loading..." even though no "loading" is happening
|
|
Reporter | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Two PRs for two possible approaches: https://github.com/mozilla/fireplace/pull/503 https://github.com/mozilla/fireplace/pull/504
|
||
Updated•10 years ago
|
Assignee: nobody → cvan
Priority: -- → P3
|
|
||
Comment 3•10 years ago
|
||
We need to uplift this change from commonplace and then we can use the `fragment_load_failed` event:
https://github.com/mozilla/commonplace/commit/c00b2d9Assignee: cvan → nobody
|
Assignee | |
Comment 4•10 years ago
|
||
https://github.com/mozilla/fireplace/commit/69e30cd90d433fffd4f7a388a78cfc6062ab49da
Assignee: nobody → kngo
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•