1035198 - webconsole "aSourceURL is undefined" error when calling 'console.log(XMLDocument)'

Status: VERIFIED FIXED

(DevTools :: Console, defect)

Description

[Patrick Brosset <:pbro>]

Attachment: test.html

The webconsole throws the following error in the browser console with the attached HTML test case: "aSourceURL is undefined utils.js:198"

STR:
- Open the attached HTML test case (tested in Aurora)
- Open the webconsole
- Open the browser console
- Click on the XMLDocument link in the console

=> The XMLDocument object isn't expanded in the object inspector and the error is thrown in the browser console

Comment 1

[Sami Jaktholm]

Attachment: console-locationless-document-nodes.patch

Here's a patch that only adds location to DOCUMENT_NODE if it has one when a DOMNode is inspected in the VariablesView. The patch contains a test case for this bug.

Try run: https://tbpl.mozilla.org/?tree=Try&rev=1846e5aa8d4c

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 8459126 [details] [diff] [review]
console-locationless-document-nodes.patch

Review of attachment 8459126 [details] [diff] [review]:
-----------------------------------------------------------------

ok! thanks for this.

::: browser/devtools/webconsole/test/head.js
@@ +48,5 @@
> + * Define an async test based on a generator function
> + */
> +function asyncTest(generator) {
> +  return () => Task.spawn(generator).then(null, ok.bind(null, false)).then(finishTest);
> +}

surprised we didn't have one of these in here already.

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/1006faf77958

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1006faf77958

Comment 6

[vasilicamihasca]

I was able to reproduce this bug on Nightly 33.0a1 (2014-07-07), using Windows 7 x64.

Verified fixed on Windows 7 x64, Mac OSX 10.9.5 and Ubuntu 14.04 x86 using Nightly 35.0a1 (2014-10-07) and Aurora 34.0a2 (2014-10-07).

This fix can be marked as verified.

[bugday-20141008]

Comment 7

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

(In reply to vasilicamihasca from comment #6)
> I was able to reproduce this bug on Nightly 33.0a1 (2014-07-07), using
> Windows 7 x64.
> 
> Verified fixed on Windows 7 x64, Mac OSX 10.9.5 and Ubuntu 14.04 x86 using
> Nightly 35.0a1 (2014-10-07) and Aurora 34.0a2 (2014-10-07).
> 
> This fix can be marked as verified.
> 
> [bugday-20141008]

Thank you for your work! Marking this as Verified.