1035211 - Changing between "Never remember history" and other settings in about:preferences#privacy and clicking "OK" in the resulting dialog is broken

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[:Gijs (he/him)]

Instead the browser console shows:

TypeError: document.documentElement.acceptDialog is not a function

privacy.js:284

Comment 1

[:Gijs (he/him)]

Attachment: don't call acceptDialog for in-content prefs,

AFAICT this can just go away. Was added in bug 842290, but in-content prefs always instant-apply, and there's no dialog to acceptDialog, so this line should just go DIAF. :-)

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Care to investigate the other acceptDialog calls in the tests (follow-up bug is fine)?

http://mxr.mozilla.org/mozilla-central/search?find=%2Fbrowser%2Fcomponents%2Fpreferences%2Fin-content%2F&string=acceptDialog

Comment 3

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/891be3548d43

Marco, can you add this for the upcoming iteration? It'll need manual verification because we don't have tests for bits that require restarts...

Comment 4

[Marco Mucci [:MarcoM]]

Added to the priority list for Iteration 33.3

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/891be3548d43

Comment 6

[Marco Mucci [:MarcoM]]

Hi Florin, can a QA contact be assigned for verification of this bug.

Comment 7

[Camelia Badau [:cbadau], Desktop QA]

Verified fixed on Mac OSX 10.8.5 using latest Nightly (buildID: 20140709030201).