Closed Bug 1035668 Opened 10 years ago Closed 10 years ago

Add Acision SMS Gateway alternative.

Categories

(Cloud Services Graveyard :: MobileID, defect)

Product:
Cloud Services Graveyard
Component:
MobileID
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: rhubscher, Unassigned)

Details

(Whiteboard: [qa?])

Attachments

(1 file)

Link to github PR
58 bytes, text/x-github-pull-request
alexis+bugs
: review-
tarek
: feedback+
Details | Review 
      No description provided.
Whiteboard: [qa?]
Attached file Link to github PR — 

        Attachment #8453027 -
        Flags: review?(alexis+bugs)

        Attachment #8453027 -
        Flags: feedback?(tarek)

    
  
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 8453027 [details] [review]
Link to github PR

Looks good beside a small possible improvement on config definition.

        Attachment #8453027 -
        Flags: feedback?(tarek) → feedback+

    
    

    
  
Comment on attachment 8453027 [details] [review]
Link to github PR

I added a few comments here and there, declining the review for now, I believe this doesn't track http errors + there are a few nits that needs to be addressed.

Feel free to r? me again when you have something updated!

        Attachment #8453027 -
        Flags: review?(alexis+bugs) → review-

    
  

        Attachment #8453027 -
        Flags: review- → review?(alexis+bugs)

    
    

    
  
Comment on attachment 8453027 [details] [review]
Link to github PR

Well, this has already been merged, but I think it could be better, so I'm letting a r-.

No big deal, but we should avoid having globals whenever we can.
No big deal, still, but please avoid merging with a pending review (even if this takes a few days).

In case of emergency, feel free to poke me so it can go faster.

        Attachment #8453027 -
        Flags: review?(alexis+bugs) → review-

    
    

    
  
Oh sorry about that. I didn't remember I had a pending review on it.
I am going to fix your review. Thank you for that.

    
    

    
  
https://github.com/mozilla-services/msisdn-gateway/commit/2a80d49b9750a8976b3ecbcb029a430c22d6d35e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

    
    

    
  
Verified in code.
Status: RESOLVED → VERIFIED

    
  
Product: Cloud Services → Cloud Services Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: