1036374 - Adding a binary search algorithm for bisection of failing tests

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Vaibhav (:vaibhav1994)]

Right now we have a reverse search algorithm for bisection of mochitests. Reverse search does well when the previous tests causing the failure are quite close to the failing test, however binary search algorithm will do better when the previous tests causing the failure will be far away.

Comment 1

[Vaibhav (:vaibhav1994)]

Attachment: binarysearch.patch

The binary search algorithm to determine the cause of failing test. 
Try run: https://tbpl.mozilla.org/?tree=Try&rev=0a6914b91de6

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8453155 [details] [diff] [review]
binarysearch.patch

Review of attachment 8453155 [details] [diff] [review]:
-----------------------------------------------------------------

overall this looks great.  Just a single suggestion for cleaning up your code ever so slightly.

::: testing/mochitest/bisection.py
@@ +160,5 @@
> +            return self.contents['testsToRun']
> +        if self.contents['loop'] == 1:
> +            self.contents['loop'] += 1
> +            self.contents['testsToRun'] = [self.contents['tests'][-1]]
> +            return self.contents['testsToRun']

if self.contents['loop'] <= 1:  #assuming this cannot be -1
    self.contents['testsToRun'] = [self.contents['tests']]
    if self.contents['loop'] == 1:
        self.contents['testsToRun'] = [self.contents['tests'][-1]]
    self.contents['loop'] += 1
    return self.contents['testsToRun']

Comment 3

[Vaibhav (:vaibhav1994)]

Attachment: binarysearch.patch

Fixed the nit pointed by jmaher in reverse search and binary search. Thanks!

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab7e8e8c1e00

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ab7e8e8c1e00