Closed
Bug 1036381
Opened 10 years ago
Closed 10 years ago
File&Compare Viewer broken
Categories
(Marketplace Graveyard :: Reviewer Tools, defect, P1)
Tracking
(Not tracked)
VERIFIED
FIXED
2014-07-15
People
(Reporter: eviljeff, Assigned: delza)
References
Details
(Keywords: regression, Whiteboard: [qa+])
TypeError: require is not a function devreg-min.js:9 It happened after the 2014-07-08 push (I believe) Static file viewing is missing all source code formatting and validation warning integration (its rendered with client side js); Compare file viewing is completely broken. e.g. https://marketplace.firefox.com/files/compare/257249...255679/
Reporter | ||
Comment 1•10 years ago
|
||
actually, static file viewing is essentially completely broken too as the file tree is missing.
Updated•10 years ago
|
Priority: -- → P2
Updated•10 years ago
|
Priority: P2 → P1
Updated•10 years ago
|
Assignee: nobody → delza
Comment 3•10 years ago
|
||
https://github.com/mozilla/zamboni/commit/867032 Sorry, Andrew, this regressed. Thanks, Dethe, for fixing this!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2014-07-15
Updated•10 years ago
|
Whiteboard: [qa+]
Comment 4•10 years ago
|
||
Please add some STR.
Assignee | ||
Comment 5•10 years ago
|
||
Assuming "STR" means "Steps to reproduce": * Using reviewer tools, find a packaged app * In the App History, click on Contents Expected: Takes you to File & Compare Viewer, shows any validation messages, allows you to load other files Actual: Takes you to File & Compare Viewer, validation never loads (shows spinner), file loading broken, console message "require is not a function devreg-min.js:9".
Comment 6•10 years ago
|
||
Verified in FF33 (Win7) The issue is no longer reproducible in marketplace-dev.allizom.org: http://screencast.com/t/V81sUqO9F0nm The is is still reproducible in stage: http://screencast.com/t/fBgZvt2QO Was this fixed pushed in stage?
Flags: needinfo?(delza)
Assignee | ||
Comment 7•10 years ago
|
||
Looks like it was not pushed on Friday. Coming soon to a staging near you.
Flags: needinfo?(delza)
Comment 8•10 years ago
|
||
Works now on stage: http://screencast.com/t/JSbMycwy Closing
Status: RESOLVED → VERIFIED
Comment 9•10 years ago
|
||
Issue still persists. Mind to reopen?
Assignee | ||
Comment 10•10 years ago
|
||
[:jpj] Still persists on which server? I believe the deployment to production was delayed until next Tuesday, so it very likely remains until then, but it should be fixed on staging and -dev.
Comment 11•10 years ago
|
||
Whoops. Wasn't aware of that.
You need to log in
before you can comment on or make changes to this bug.
Description
•