1037354 - Remove the obsolete references to the TelephonyCall.number and TelephonyCall.secondNumber fields

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Gabriele Svelto [:gsvelto]]

+++ This bug was initially created as a clone of Bug #1005766 +++

Bug 981519 replaced TelephonyCall.number and TelephonyCall.secondNumber with TelephonyCall.id and TelephonyCall.secondId. In bug 1005766 we landed some compatibility glue in Gaia to ensure the callscreen would work with both. Now that the Gecko change has stuck it's time to remove the use of the obsolete fields from Gaia.

Comment 1

[Doug Sherk (:drs) (inactive)]

Attachment: Remove the obsolete references to the TelephonyCall.number and TelephonyCall.secondNumber fields.

PR: https://github.com/mozilla-b2g/gaia/pull/24541

Etienne, feel free to redirect the dialer component to Gabriele. I thought it would make more sense for you to just review the whole thing since this is such a small and clear change.

Comment 2

[Etienne Segonzac (:etienne)]

Comment on attachment 8497298 [details] [diff] [review]
Remove the obsolete references to the TelephonyCall.number and TelephonyCall.secondNumber fields.

Review of attachment 8497298 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the remaining |secondNumber| references in |dialer.js| (and |dialer_test.js|) fixed (cdma stuff, might have been broken for a while...)

Comment 3

[Doug Sherk (:drs) (inactive)]

Attachment: Remove the obsolete references to the TelephonyCall.number and TelephonyCall.secondNumber fields.

Yikes, good catch. I didn't think that was referring to a TelephonyCall object. Carrying r+.

Comment 4

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/0e280591881d44b80f456bc27e12d9114c218868

Comment 5

[Doug Sherk (:drs) (inactive)]

Attachment: Followup, fix incorrect changes to id.secondNumber.

(In reply to Etienne Segonzac (:etienne) from comment #2)
> Comment on attachment 8497298 [details] [diff] [review]
> Remove the obsolete references to the TelephonyCall.number and
> TelephonyCall.secondNumber fields.
> 
> Review of attachment 8497298 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with the remaining |secondNumber| references in |dialer.js| (and
> |dialer_test.js|) fixed (cdma stuff, might have been broken for a while...)

Thanks for being thorough on this. Unfortunately, I should have tested this, as it was wrong, and it is actually a different object. Here's a followup to back out that portion of the changes.

PR: https://github.com/mozilla-b2g/gaia/pull/24579

Comment 6

[Doug Sherk (:drs) (inactive)]

Attachment: Followup, fix incorrect changes to id.secondNumber.

Comment 7

[Doug Sherk (:drs) (inactive)]

Backed out of master: https://github.com/mozilla-b2g/gaia/commit/023674ab6fe8daa74fb623cda5274e396146ec47

Comment 8

[Doug Sherk (:drs) (inactive)]

Attachment: Remove the obsolete references to the TelephonyCall.number and TelephonyCall.secondNumber fields.

PR: https://github.com/mozilla-b2g/gaia/pull/24589

Sorry about the trainwreck here. This is a rollup of the original fix and the followup. I did manual testing this time.

Comment 9

[Etienne Segonzac (:etienne)]

Comment on attachment 8497914 [details] [diff] [review]
Remove the obsolete references to the TelephonyCall.number and TelephonyCall.secondNumber fields.

Review of attachment 8497914 [details] [diff] [review]:
-----------------------------------------------------------------

triple-checked

Comment 10

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/4083d159cc76502bd3318b8676801abb4ebef630