1037756 - Move cloneSingletons to CompartmentOptions

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bobby Holley (:bholley)]

Right now this thing is set up as a per-compartment override of a per-context default, but nobody ever changes the default on the context. That makes this very easy to fix.

Comment 1

[Bobby Holley (:bholley)]

Attachment: Move cloneSingletons to CompartmentOptions. v1

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8455488 [details] [diff] [review]
Move cloneSingletons to CompartmentOptions. v1

Review of attachment 8455488 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsapi.h
@@ +2597,5 @@
>          return *this;
>      }
>  
>  
> +    bool cloneSingletons(JSContext *cx) const { return cloneSingletons_; }

Remove the |cx| argument, r=me with that.

Comment 3

[Bobby Holley (:bholley)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b0111ca90e2

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3b0111ca90e2