1037908 - Inspector tooltip text has unwanted text-shadow with certain light-weight themes

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Mark Bokil]

Attachment: inspector-retina-blurry-tooltip.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140710141843

Steps to reproduce:

Open inspector and inspect an element on a OS X retina device like macbook pro


Actual results:

tooltip text is readable but blurry (over aliased). see attached screenshot of text issue.


Expected results:

tooltip text should be sharp

Comment 1

[:Gijs (he/him)]

I can't reproduce this. Can you check if you can reproduce this if you restart with add-ons disabled (option in the help menu)? And do you perhaps have a theme installed/enabled?

Comment 2

[Mark Bokil]

I confirmed it was the silver2 theme interacting with the tooltip. Marking as resolved invalid.

Comment 3

[:Gijs (he/him)]

Because silver2 is a "light-weight theme", it's still Firefox's responsibility to make the text in its tooltips look good in that case, so I'm reopening this.

The issue is that for lightweight themes with a certain background/foreground color, we set a bright text shadow. That's what you're seeing here. Because the text shadow doesn't work well in this case, the inspector's CSS should include a line or two to disable it in such cases.

Theme: https://addons.mozilla.org/en-us/firefox/addon/silver2/

Comment 4

[Mark Bokil]

I see your point. Other light-weight themes may also show the blurring from the shadow and users will most likely see it as a Firefox bug.

Comment 5

[Brian Grinstead [:bgrins]]

Attachment: fuzzy-text.patch

There is a text shadow applied to :root:-moz-lwtheme-darktext and :root:-moz-lwtheme-brighttext.  This removes it for the infobar

Comment 6

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/dc73c687701d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dc73c687701d