1038079 - Change all IMEI in all testvars files to be an array with one or both IMEI codes.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

In order to be able to test with dual IMEI numbers we need to update the testvars files to be an array.

Comment 1

[raymond [:retornam] (inactive)]

(In reply to Zac C (:zac) from comment #0)
> In order to be able to test with dual IMEI numbers we need to update the
> testvars files to be an array.

This has to be done manually since there is no way to do this automatically.I'll have to take all the phones down to do this at a sitting. We should have kept the dual IMEI pull requests i submitted earlier.

Comment 2

[Dylan Chun Wong [:dwong]]

Attachment: PR to change all testvars to use arrays for IMEI's

Comment 3

[raymond [:retornam] (inactive)]

(In reply to Dylan Chun Wong [:dwong] from comment #2)
> Created attachment 8455658 [details] [review]
> PR to change all testvars to use arrays for IMEI's

Zac, can you take a look at the pull request since this changes for the Hamachi's as well,

Comment 4

[Zac C (:zac)]

Sure, I've already lined up test changes to deal with the 'data model' changes.

Comment 5

[Zac C (:zac)]

Merged!
https://github.com/mozilla/webqa-credentials/commit/ef3a910070c2d1145a1bb383fa7657f8a725ca75

Thanks Dylan for your hard work on this.

Comment 6

[Robert Chira [:RobertC]]

I looked over the PR and I see that in 2 of the files the imei list contains the same code twice.
The files in question are:
b2g-2.json
b2g-17.2.json

Comment 7

[raymond [:retornam] (inactive)]

(In reply to Robert Chira [:RobertC] from comment #6)
> I looked over the PR and I see that in 2 of the files the imei list contains
> the same code twice.
> The files in question are:
> b2g-2.json
> b2g-17.2.json

Dwong can you please look at this?

Comment 8

[Dylan Chun Wong [:dwong]]

Attachment: PR to amend b2g-2 and b2g-17.2

Comment 9

[[:AndreiH]]

Thanks guys!

Comment 10

[[:AndreiH]]

https://github.com/mozilla/webqa-credentials/commit/eb3597586fd41a95cdeaf66c208396223107bfe2