1038150 - Make nsAnonTempFileRemover's destructor private and also remove the useless ctor/dtor counting macros

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[(no longer active)]

Attachment: Make nsAnonTempFileRemover's destructor private and also remove the useless ctor/dtor counting macros

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 8455317 [details] [diff] [review]
Make nsAnonTempFileRemover's destructor private and also remove the useless ctor/dtor counting macros

Review of attachment 8455317 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see why the counting macros are useless here.

Comment 3

[Andrew McCreight [:mccr8]]

ISupports refcounting does the same thing as COUNT_CTOR/DTOR.

Comment 4

[(no longer active)]

Comment on attachment 8455317 [details] [diff] [review]
Make nsAnonTempFileRemover's destructor private and also remove the useless ctor/dtor counting macros

What mccr8 said.

Comment 5

[Andrew McCreight [:mccr8]]

One interesting thing is that I think if you are using a refcounted class improperly and never addref/release it, then you won't get leak tracking, so COUNT_CTOR is useful. But I think thanks to the work to hide dtors that shouldn't be as much of a problem any more.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/164c1eef200a