1038311 - Hit testing doesn't work correctly.

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Bijan Naimi]

Attachment: TheLineGameFinished.fla

The car should stop when it's off the track.

Comment 1

[Till Schneidereit [:till]]

Fixed by https://github.com/mozilla/shumway/commit/93e379e0978c07b83df9f5921441f43ebb625428

Sorry about regressing that.

Comment 2

[Michael Bebenita [:mbx]]

Attachment: acid-click-0.fla

Comment 3

[Michael Bebenita [:mbx]]

Clicking on the lighter colored part of the shape does not work. Normally a shape like this is composed of two disjoint paths. In this case, I *think* the IDE generates two overlapping paths because of the way the SWF was authored. The hit testing algorithm probably thinks the point is outside, since it is inside of two paths.

Comment 4

[Tobias Schneider [:tobytailor]]

I think we just have to return earlier whenever we start a new sub-shape (which happens when the fill/line style changes) and the hit-test is already positive at that point.

Comment 5

[Tobias Schneider [:tobytailor]]

Fixed by https://github.com/tobytailor/shumway/commit/64e6ff470af59ea115a799fe730a848f067e8c63.