Closed Bug 1038390 Opened 10 years ago Closed 10 years ago

Make Your Own Make-Masonry

Categories

(Webmaker Graveyard :: Teaching Kits / Curriculum, defect)

Product:
Webmaker Graveyard
Component:
Teaching Kits / Curriculum
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: akirose, Assigned: akirose)

References

Details

(Whiteboard: [tech-debt])

Attachments

(1 file)

https://github.com/mozilla/webmaker.org/pull/953
48 bytes, text/x-github-pull-request
Details | Review 
The makes on /make-your-own would be better displayed if masonry was rendering them as 300px bricks. I don't think we've pulled masonry into the angular app yet. Idk if that's a thing or not.
See Also: → 1038389
Whiteboard: [techdebt] → [tech-debt]
Looking for feedback, left a Q on the PR.
Assignee: nobody → aki
Status: NEW → ASSIGNED
Attachment #8479546 - Flags: feedback?(kate)
Attachment #8479546 - Flags: feedback?(kate) → review?(kate)
Commits pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/4f489bf111c8d9b1078e3db837939c174fcb147d
Bug 1038390 - Make Your Own Make-Masonry

https://github.com/mozilla/webmaker.org/commit/a9f87bc4d26935c27cc9d59e216e5aba4256136e
Merge pull request #953 from gesa/1038390/masonry

Fixes Bug 1038390 - Make Your Own Make-Masonry & Fixes Bug 1059425 - "Make Your Own" makes should use new make directive
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #8479546 - Flags: review?(kate)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: