1038411 - Give myDownloadObserver a private destructor

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Comment 1

[(no longer active)]

Attachment: Give myDownloadObserver a private destructor

Comment 2

[(no longer active)]

Just adding a dtor breaks b2g desktop builds on Windows because they don't have MOZ_PLACES defined.  I think we should hide this class there completely.

Comment 3

[(no longer active)]

(In reply to :Ehsan Akhgari (lagging on bugmail, needinfo? me!) from comment #2)
> Just adding a dtor breaks b2g desktop builds on Windows because they don't
> have MOZ_PLACES defined.  I think we should hide this class there completely.

https://tbpl.mozilla.org/php/getParsedLog.php?id=43847535&tree=Mozilla-Inbound#error0

Comment 4

[(no longer active)]

Attachment: Give myDownloadObserver a private destructor

Comment 5

[Marco Bonardo [:mak]]

Comment on attachment 8456428 [details] [diff] [review]
Give myDownloadObserver a private destructor

Review of attachment 8456428 [details] [diff] [review]:
-----------------------------------------------------------------

I was not aware of this code. What a fancy class name! :)

Btw, I think this makes sense, since this class is only used in code that is already wrapped by MOZ_PLACES

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f22e1fd54e85

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f22e1fd54e85