1038486 - Fix Linux desktop sandbox build on 32-bit x86

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

We have some macros to used by the B2G whitelist to deal with architecture-dependent system calls (history of off_t size, etc.), but the first-draft desktop whitelist doesn't use them.  Unsurprisingly, it doesn't even build on 32-bit x86 (or ARM) at the moment, but this is fixable.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: bug1038486-sandbox-desktop-arch-hg0.diff

It would be nice if we could just remove the SysV IPC calls instead of dealing with whitelisting them, but that can be a followup.

Try run: https://tbpl.mozilla.org/?tree=Try&rev=ce4562e547e2 (ignore the Fennec x86 red; it shouldn't be using the desktop policy in the first place, but that's also a separate bug).

Comment 2

[Guillaume Destuynder [:kang] [this account is no longer active]]

Comment on attachment 8455843 [details] [diff] [review]
bug1038486-sandbox-desktop-arch-hg0.diff

Review of attachment 8455843 [details] [diff] [review]:
-----------------------------------------------------------------

Right - first we need this working at all :)
Looks good.

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ea86a380019

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3ea86a380019