Closed Bug 10386 Opened 25 years ago Closed 25 years ago

[FIX] dialshr.cpp calling getPhoneBookNT() on non-NT machines

Categories

(CCK Graveyard :: CCK-General, defect, P3)

Product:
CCK Graveyard
Component:
CCK-General
Platform:
Other
Other
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED INVALID

People

(Reporter: jordy, Assigned: selmer)

Details

Right around line 2332, in cck/muc/dialshr.cpp you have this block of code:

	// Creating connection entry!
   	char*		pbPath = NULL;

	if ( gPlatformOS = VER_PLATFORM_WIN32_NT )
		pbPath = getPhoneBookNT();
	else
		pbPath = (char*)account.ISPName;

Line 2332 itself should read:

	if ( gPlatformOS == VER_PLATFORM_WIN32_NT )

if I'm not mistaken (== not =).
Same thing on line 2362, this code will always execute:

	ret = ( dwRet == 0 );

	if ( gPlatformOS = VER_PLATFORM_WIN32_NT )
	{
		RASCREDENTIALS credentials;

		// sets up user login info for new phonebook entry

Line 2362:

	if ( gPlatformOS = VER_PLATFORM_WIN32_NT )

Should read

	if ( gPlatformOS == VER_PLATFORM_WIN32_NT )
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → INVALID
Woops, didn't realize there was more than one version of dialshr.cpp in the
tree.
Status: RESOLVED → VERIFIED
Marking Verified/Invalid
->CCK-General. Other CCK Components going away.
Component: Dialup-Mup/Muc → CCK-General
You need to log in before you can comment on or make changes to this bug.