Closed Bug 103867 Opened 23 years ago Closed 22 years ago

[PATCH]Changing a partial selection of text with a paragraph style causes the selection to include the entire text

Categories

(Core :: DOM: Selection, defect, P2)

Product:
Core
Component:
DOM: Selection
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: TucsonTester2, Assigned: mozeditor)

Details

(Whiteboard: EDITORBASE+ [adt2] FIXINHAND; need a=)

Attachments

(1 file)

patch to nsSelectionState.cpp
1.18 KB, patch
glazou
: review+
kinmoz
: superreview+
asa
: approval+
Details | Diff | Splinter Review 
Build ID: 20011004

Changing the paragraph of a partial selection of text with a paragraph style
causes the selection to include the entire text.

Reproducible:  Always

Steps to Reproduce:
1.Open composer
2.Click on the paragraph style drop-down on the toolbar and choose address
3.Type in 5 lines of text
4.Highlight the first 3 lines of the text
5.Click on the paragraph style drop-down on the toolbar and choose body text

Actual Results:
All 5 lines will be highlighted.  This happens with the paragraph, address,
preformat paragraph styles.  This also happens if you outdent part of a blockquote.

Expected Results:
I would expect that the selection would only highlight what I had selected. 
Changing a paragraph style should not add to the selection.
Selection bug.
Assignee: syd → mjudge
Component: Editor: Composer → Selection
Confirmed. (BuildID: 2001100903)

(note: style changed as expected, its only the selection after the change that
is wrong)
I think its related to another selection problem: bug 104240
Confirming on build 2001111203.
Status: UNCONFIRMED → NEW
Ever confirmed: true
joe's rules code. EDITORBASE, looks like Joe is leaving selection on the whole 
thing.
Assignee: mjudge → jfrancis
forgot to nominate for EDITORBASE.
setting to 1.0.
Whiteboard: EDITORBASE
Target Milestone: --- → mozilla1.0
if no one can reproduce this on tip i will assume i have fixed it with other
work.  so far this is WFM.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → WORKSFORME
verified.
Status: RESOLVED → VERIFIED
I am still seeing this problem on the 02-13 trunk build on Win ME.  

I am reopening this bug.
Status: VERIFIED → REOPENED
Resolution: WORKSFORME → ---
ok - i see it on tip.  Earlier comment was with a build that has some patches
that have not yet landed.  I'll try to get this for 099.
Status: REOPENED → ASSIGNED
Target Milestone: mozilla1.0 → mozilla0.9.9
I'll go ahead and nominate this one.  It's borderline in my book.
Whiteboard: EDITORBASE → EDITORBASE, nsbeta1
Plussing, behaviour is unexpected and may cause user to get confused.
Retargetting to mozilla 1.0
Keywords: nsbeta1+
Whiteboard: EDITORBASE, nsbeta1 → EDITORBASE+
Target Milestone: mozilla0.9.9 → mozilla1.0
pri = 2 for original 1.0 EB+ bugs
Priority: -- → P2
Whiteboard: EDITORBASE+ → EDITORBASE+ [adt2]
fixed a logic error
Whiteboard: EDITORBASE+ [adt2] → EDITORBASE+ [adt2] FIXINHAND; need r,sr,a=
Comment on attachment 77029 [details] [diff] [review]
patch to nsSelectionState.cpp

Abzolutely, Herr Vranzis !
r=glazman
Attachment #77029 - Flags: review+
Summary: Changing a partial selection of text with a paragraph style causes the selection to include the entire text → [PATCH]Changing a partial selection of text with a paragraph style causes the selection to include the entire text
Comment on attachment 77029 [details] [diff] [review]
patch to nsSelectionState.cpp

sr=kin@netscape.com
Attachment #77029 - Flags: superreview+
Whiteboard: EDITORBASE+ [adt2] FIXINHAND; need r,sr,a= → EDITORBASE+ [adt2] FIXINHAND; need a=
adt1.0.0
Keywords: adt1.0.0, approval
Comment on attachment 77029 [details] [diff] [review]
patch to nsSelectionState.cpp

a=asa (on behalf of drivers) for checkin to the 1.0 trunk
Attachment #77029 - Flags: approval+
adt1.0.0+ (on ADT's behalf) approval for checkin into 1.0.
Keywords: adt1.0.0 → adt1.0.0+
fix landed on trunk
Status: ASSIGNED → RESOLVED
Closed: 23 years ago → 22 years ago
Resolution: --- → FIXED
Tucson, please verify this on latest build...thanks...
Verified on 04-08 trunk.
Status: RESOLVED → VERIFIED
This landed before branch cut.  Hence: fixed1.0.0
Keywords: approval → fixed1.0.0
Verified 04-19 1.0.0 branch.
Keywords: fixed1.0.0 → verified1.0.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: