Closed Bug 1038676 Opened 10 years ago Closed 10 years ago

Do not select SMS MO+MT flow unless there is an available charge free number

Categories

(Cloud Services Graveyard :: MobileID, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ferjm, Assigned: rhubscher)

References

Details

(Whiteboard: [qa?])

Attachments

(1 file)

59 bytes, text/x-github-pull-request
alexis+bugs
: review+
ferjm
: feedback+
Details | Review
The MSISDN dev server is currently offering the MO+MT verification flow based only in the absence of a client known MSISDN without checking if the known "moVerifier" number for the given mcc/mnc is free of charge for the user. This means that the client will be sending messages that will potentially cost the user money without even telling the user about it. We need to change this for the production server, so we only offer the MO+MT flow when we have a known "moVerifier" number *AND* this number is free of charge for the user.
Assignee: nobody → ferjmoreno
How do you know if the number is free of charge for the user?
Because you bought/hired/agreed it with the provider :)
Actually, this might not even need a patch and can probably be solved via configuration. We just need to remove the "moVerifier" numbers that are not free in production (I guess that would be all numbers for now). Am I right?
Flags: needinfo?(rhubscher)
I meant removing "moVerifier" and "moVerifierList" from the production configuration
Although from mobile phones, are free phone numbers free with all providers?
For instance in the UK with Ofcom 0800 will be free from all mobiles from June 2015 only...
http://www.theguardian.com/media/2013/dec/12/ofcom-free-0800-mobile-telecoms-overhaul
We need to provide a new configuration to define that if we don't find the number in the list we should deactivate the MOMT flow.

Romain, we can configure it wrt MCC and MNC so I guess we have enough information to tell if the short code is free.

Also for now Nexmo is only providing us with US Short Codes.
Flags: needinfo?(rhubscher)
Whiteboard: [qa?]
Rémy, since this is a server configuration change, I am assigning the bug to you. Please, reassign it to someone else if that's not correct. Thanks!
Assignee: ferjmoreno → rhubscher
Ok thanks.
Attached file Link to github PR
Attachment #8456881 - Flags: review?(alexis+bugs)
Attachment #8456881 - Flags: feedback?(ferjmoreno)
Status: NEW → ASSIGNED
Attachment #8456881 - Flags: feedback?(ferjmoreno) → feedback+
Attachment #8456881 - Flags: review?(alexis+bugs) → review+
https://github.com/mozilla-services/msisdn-gateway/commit/35f1da6d13b2300ab3b3f8eaafcb4089adff2750
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: Cloud Services → Cloud Services Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: